Review main Abandoned

89995[WIP][TASK] collectionservice

Christian Kuhn CR 0 V 0 Hard +114 −229 updated 04/21/26, 14:54

Commit message

* Minor cleanup in WorkspaceService

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 3

Review log 1014

  1. Christian Kuhn uploaded patch set 1 07/06/25, 10:04

  2. core-ci voted on patch set 1 V +1 07/06/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81364

  3. Christian Kuhn uploaded patch set 2 V +1 07/06/25, 10:43

  4. core-ci voted on patch set 2 V +1 07/06/25, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81367

  5. Christian Kuhn commented on patch set 2 07/06/25, 13:34

    set 1: move CollectionService->getDependencyResolver into GridDataService and hand DependencyResolver around instead.
  6. Christian Kuhn commented on patch set 2 07/06/25, 13:35

    set 2: clean up WorkspaceService
  7. Christian Kuhn uploaded patch set 3 07/06/25, 13:39

  8. Christian Kuhn commented on patch set 3 07/06/25, 13:39

    set 3: hand $dataArray around in CollectionService
  9. core-ci voted on patch set 3 V +1 07/06/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81370

  10. Christian Kuhn uploaded patch set 4 V +1 07/06/25, 13:49

  11. Christian Kuhn commented on patch set 4 07/06/25, 13:51

    set 4: GridDataService->sortDataArray() is completely useless since Workspaces_CollectionLevel of both $a and $b is *always* 0 at this point, so the comparison closure always early returns 0, the true sorting is later done within resolveDataArrayDependencies().
  12. core-ci voted on patch set 4 V +1 07/06/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81371

  13. Benni Mack marked it work in progress 12/18/25, 11:19

  14. Christian Kuhn abandoned the change 04/21/26, 14:54