Review main Merged

89999[TASK] Avoid useless sorting in GridDataService

Christian Kuhn CR +2 V +2 Easy +7 −43 updated 07/07/25, 21:44

Commit message

Looking closer at GridDataService->sortDataArray() after #106973
simplified the logic, it turns out the code is useless: At this
point array key Workspaces_CollectionLevel is always 0 (it is
filled only later by resolveDataArrayDependencies()), so the
uasort() closure always early returns 0.
The patch removes sortDataArray() and keeps the event only.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/07/25, 00:57

  2. core-ci voted on patch set 1 V +1 07/07/25, 01:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81382

  3. Christian Kuhn uploaded patch set 2 V +1 07/07/25, 01:13

  4. core-ci voted on patch set 2 V +1 07/07/25, 01:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81384

  5. Benni Mack voted on patch set 2 CR +1 V +1 07/07/25, 08:17

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 07/07/25, 10:11

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 07/07/25, 21:32

  8. Christian Kuhn merged patch set 3 07/07/25, 21:44