Review main Merged

90000[TASK] Raise php-cs-fixer

Christian Kuhn CR +2 V +2 Normal +33 −32 updated 07/07/25, 21:07

Commit message

> composer req --dev friendsofphp/php-cs-fixer:^3.81.0
> Build/Scripts/runTests.sh -s cgl -p 8.2

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1619

  1. Christian Kuhn uploaded patch set 1 07/07/25, 01:27

  2. core-ci voted on patch set 1 V +1 07/07/25, 01:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81385

  3. Benni Mack commented on patch set 1 07/07/25, 07:16

    SudoModeVerifyEvent.php:30

    This is weird, why should we change the order for the $password property, but not for the $useInstallToolPassword property?
  4. Christian Kuhn uploaded patch set 2 V +1 07/07/25, 10:10

  5. Christian Kuhn commented on patch set 1 07/07/25, 10:10

    SudoModeVerifyEvent.php:30 Reply

    maybe that fixer is incomplete. i did that manually now.
  6. core-ci voted on patch set 2 V +1 07/07/25, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81404

  7. Oliver Klee voted on patch set 2 CR +1 V +1 07/07/25, 10:43

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 07/07/25, 10:55

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 07/07/25, 11:26

  10. Georg Ringer voted on patch set 2 CR +1 V +1 07/07/25, 11:59

  11. Oliver Klee commented on patch set 2 07/07/25, 16:10

    In the meantime, v3.81.0 has been released. So we might want to directly upgrade to that version. https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.81.0
  12. Oliver Klee commented on patch set 2 07/07/25, 16:11

    Reply

    (unresolving)
  13. Christian Kuhn uploaded patch set 3 CR +1 V +1 07/07/25, 17:38

  14. Christian Kuhn commented on patch set 2 07/07/25, 17:38

    Reply

    Done
  15. core-ci voted on patch set 3 V +1 07/07/25, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81438

  16. Oliver Klee voted on patch set 3 CR +1 V +1 07/07/25, 17:55

  17. Garvin Hicking voted on patch set 3 CR +1 V +1 07/07/25, 19:06

  18. Christian Kuhn voted on patch set 3 CR +2 V +2 07/07/25, 21:07

  19. Christian Kuhn merged patch set 4 07/07/25, 21:07