Review main Abandoned

90001[POC][TASK] Make Site Settings YAML location configurable via ENV

Garvin Hicking CR 0 V 0 Easy +33 −2 updated 07/15/25, 18:42

Commit message

This allows to set an ENV variable to define the path to the
site set settings.yaml base directory. This allows to distinguish
locations for "config.yaml" (=git maintained) and "settings.yaml"
(=GUI maintained)

.env:
```
TYPO3_PATH_SITE_SETTINGS=/var/www/html/config/deploy-sites
```

(see also: TYPO3_PATH_APP, TYPO3_PATH_ROOT, TYPO3_PATH_COMPOSER_ROOT)

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 6

Review log 710

  1. Garvin Hicking uploaded patch set 1 07/07/25, 08:38

  2. Garvin Hicking marked it work in progress 07/07/25, 08:39

  3. Mathias Brodala commented on patch set 1 07/07/25, 08:44

    Environment.php:242

    This should be TYPO3_SITE_SETTINGS_PATH to stay in line with existing environment variables and the naming of these in general.
  4. core-ci voted on patch set 1 V -1 07/07/25, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81396

  5. Garvin Hicking uploaded patch set 2 V -1 07/07/25, 08:54

  6. Garvin Hicking uploaded patch set 3 07/07/25, 08:56

    CGL
  7. core-ci voted on patch set 3 V +1 07/07/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81398

  8. core-ci voted on patch set 2 V -1 07/07/25, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81397

  9. Garvin Hicking commented on patch set 3 07/07/25, 10:42

    Environment.php:242 Reply

    ack thx!
  10. Garvin Hicking abandoned the change 07/15/25, 18:42

    Not doing. https://review.typo3.org/c/Packages/TYPO3.CMS/+/90064 resolves it less impactful.