Review 13.4 Merged

90005[TASK] Avoid useless sorting in GridDataService

Christian Kuhn CR +2 V +2 Easy +8 −41 updated 07/07/25, 21:44

Commit message

Looking closer at GridDataService->sortDataArray() after #106973
simplified the logic, it turns out the code is useless: At this
point array key Workspaces_CollectionLevel is always 0 (it is
filled only later by resolveDataArrayDependencies()), so the
uasort() closure always early returns 0.
The patch removes sortDataArray() and keeps the event only.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/07/25, 21:26

  2. core-ci voted on patch set 1 V +1 07/07/25, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81444

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 07/07/25, 21:44

  4. Christian Kuhn merged patch set 2 07/07/25, 21:44