Review main Merged

90029[TASK] Simplify workspaces StagesService

Christian Kuhn CR +2 V +2 Hard +70 −203 updated 07/09/25, 13:10

Commit message

Yet another step to disentangle internal workspace classes:

* Refactor getWorkspaceId() away
* Remove unused getNextStages(), getPrevStages(), isValid()
* Simplify signature of getPreviousStageForElementCollection()
  and getNextStageForElementCollection()
* Inline single use of TABLE_STAGE constant
* Inline inconsistently used property $pathToLocallang
* Remove unused FE related label_nextStage, label_prevStage,
  path_Live and languageValue. This reduces DB load, especially
  when custom workspace stages are involed.
* Straighten StageRecord and WorkspaceRecord

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1218

  1. Christian Kuhn uploaded patch set 1 07/08/25, 22:04

  2. core-ci voted on patch set 1 V +1 07/08/25, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81500

  3. Christian Kuhn uploaded patch set 2 V +1 07/08/25, 22:42

  4. core-ci voted on patch set 2 V +1 07/08/25, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81501

  5. Christian Kuhn uploaded patch set 3 V +1 07/08/25, 23:10

  6. core-ci voted on patch set 3 V +1 07/08/25, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81502

  7. Christian Kuhn uploaded patch set 4 V +1 07/09/25, 00:24

  8. core-ci voted on patch set 4 V +1 07/09/25, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81503

  9. Christian Kuhn updated the commit message in patch set 5 V +1 07/09/25, 08:09

  10. core-ci voted on patch set 5 V +1 07/09/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81518

  11. Benni Mack voted on patch set 5 CR +1 V +1 07/09/25, 08:29

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 07/09/25, 10:28

  13. Christian Kuhn uploaded patch set 6 CR +1 V +1 07/09/25, 12:10

  14. Benni Mack voted on patch set 6 CR +1 V +1 07/09/25, 12:13

  15. core-ci voted on patch set 6 V +1 07/09/25, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81526

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 07/09/25, 12:29

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 07/09/25, 13:10

  18. Christian Kuhn merged patch set 7 07/09/25, 13:10