Review main Merged

90030[BUGFIX] Avoid PHP type error in SlugHelper in workspace context

Oliver Hader CR +2 V +2 Easy +8 −19 updated 07/09/25, 12:01

Commit message

Issue #102722 introduced the strict `?array` return type in
`SlugHelper` when performing workspace overlays for the given
page records. Since the invoked function `BackendUtility::workspaceOL`
might return `false` in addition, a PHP type error is thrown.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Lisa Kreitz +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Lisa Kreitz +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 67

  1. Oliver Hader uploaded patch set 1 07/09/25, 09:22

  2. core-ci voted on patch set 1 V +1 07/09/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81519

  3. Benni Mack voted on patch set 1 CR +1 V +1 07/09/25, 09:58

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 07/09/25, 10:19

  5. Lisa Kreitz voted on patch set 1 CR +1 V +1 07/09/25, 11:40

  6. Oliver Hader voted on patch set 1 CR +2 V +2 07/09/25, 12:01

  7. Oliver Hader merged patch set 2 07/09/25, 12:01