90032[TASK] Update to CKEditor 5 46.1.1
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 67
- Build/overrides/ckeditor5/package.json+1 −1
- Build/rollup/ckeditor.js+2 −2
- Build/Sources/TypeScript/rte-ckeditor/plugin/typo3-link.ts+5 −5
- Build/Sources/TypeScript/rte-ckeditor/plugin/whitespace.ts+1 −1
- Build/Sources/TypeScript/rte-ckeditor/ckeditor5.ts+6 −6
- Build/Sources/TypeScript/rte-ckeditor/rte-link-browser.ts+3 −3
- Build/package-lock.json+486 −467
- Build/package.json+40 −40
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96874-CKEditor-relatedPluginsAndConfiguration.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96874-CKEditor5.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-99237-MagicImageService.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.4.x/Deprecation-102099-DeprecateCKEditor5BundleModule.rst+7 −7
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-100847-AddedFontPluginToCKEditor5.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-102507-DefaultCKEditor5AllowedClassesAndDataAttributesConfiguratedReverted.rst+7 −7
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-104827-AllowToUseRegularExpressionsInCKEditorYAML.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-107063-CKEditor5-v46.rst2new+78 −0
- typo3/sysext/rte_ckeditor/Classes/Configuration/CKEditor5Migrator.php2+13 −13
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+1 −1
- typo3/sysext/rte_ckeditor/Configuration/RTE/Full.yaml+3 −3
- typo3/sysext/rte_ckeditor/Documentation/Configuration/Examples.rst+5 −5
Show 47 more files
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-alignment.js+6 −6
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-autoformat.js+4 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-basic-styles.js+14 −14
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-block-quote.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-clipboard.js+18 −18
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-code-block.js+12 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-core.js+16 −19
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-classic.js+4 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-decoupled.js+4 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-multi-root.js+4 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-engine.js+125 −115
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-enter.js+7 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-find-and-replace.js+14 −14
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-font.js+23 −23
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-fullscreen.js+12 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-heading.js+8 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-highlight.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-horizontal-line.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-html-support.js+23 −23
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-icons.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-image.js+59 −59
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-indent.js+8 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-inspector.js+27 −29
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-language.js+6 −6
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-link.js+18 −18
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-list.js+60 −51
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-mention.js+8 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paragraph.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paste-from-office.js+22 −19
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-remove-format.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-select-all.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-special-characters.js+12 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-style.js+13 −13
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-table.js+84 −84
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-typing.js+15 −15
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-ui.js+107 −107
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-undo.js+7 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-upload.js+4 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-utils.js+77 −67
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-watchdog.js+8 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-widget.js+12 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-word-count.js+4 −4
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ja.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/ckeditor5.js+1 −1
- typo3/sysext/rte_ckeditor/Tests/Functional/Fixtures/RteConfigArrayFixture.yaml+3 −3
- typo3/sysext/rte_ckeditor/Tests/Functional/Fixtures/RteConfigStringFixture.yaml+3 −3
- typo3/sysext/rte_ckeditor/Tests/Unit/Configuration/CKEditor5MigratorTest.php+20 −20
Review log 2941
Show 1016 earlier messages
-
Garvin Hicking uploaded patch set 1 07/09/25, 10:34
-
core-ci voted on patch set 1 V +1 07/09/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81522
-
Garvin Hicking uploaded patch set 2
V +107/30/25, 08:05 -
Garvin Hicking uploaded patch set 3 07/30/25, 08:10
-
core-ci voted on patch set 2 V -1 07/30/25, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82543
-
core-ci voted on patch set 3 V -1 07/30/25, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82544
-
Göran Bodenschatz updated the commit message in patch set 4
V -108/01/25, 15:37 -
core-ci voted on patch set 4 V -1 08/01/25, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82639
-
Göran Bodenschatz commented on patch set 4 08/01/25, 15:52
-
Garvin Hicking uploaded patch set 5
V -108/19/25, 10:03 -
Garvin Hicking commented on patch set 5 08/19/25, 10:04
Breaking-107063-CKEditor5-v46.rst:6ReplyYou are right, I unified the naming to be called like this. As a project that pays attention to its proper product naming, I think we deserve to also use the proper spelling for our dependencies. Thank you for pointing this out! -
Garvin Hicking commented on patch set 5 08/19/25, 10:04
Breaking-107063-CKEditor5-v46.rst:6ReplyDone -
core-ci voted on patch set 5 V +1 08/19/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83602
-
Garvin Hicking uploaded patch set 6
V +109/03/25, 07:57 -
Garvin Hicking uploaded patch set 7 09/03/25, 08:01
-
core-ci voted on patch set 6 V -1 09/03/25, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84305
-
core-ci voted on patch set 7 V +1 09/03/25, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84306
-
Garvin Hicking uploaded patch set 8
V +109/10/25, 08:10v46 1 0 -
core-ci voted on patch set 8 V +1 09/10/25, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84764
-
Göran Bodenschatz voted on patch set 8 CR +1 09/10/25, 12:25
-
Garvin Hicking uploaded patch set 9
CR +1V +109/15/25, 09:21Groundhog day for 46 1 1 -
core-ci voted on patch set 9 V +1 09/15/25, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84978
-
Benjamin Franzke commented on patch set 9 09/23/25, 07:20
Let's try to bring this into v13 as well, I commented on the Breaking.rst and think that this can be downgraded to an Important.rst (or even completely omitted by "migrating" CSS on-the-fly)Breaking-107063-CKEditor5-v46.rst:16We basically prepared for the entirety of this change with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81323 That means: We do *only* use named exports of the main entry point npm-packages, and we only expose those as API to be usable for extensions (via our importmap). That means: The exports that are not being removed/unsupported were not supported in our environment at all. => Not a breaking change. Users that compile via TypeScript against ckeditor sources may need to adapt some *type* (so compile-time) imports upgrading from 45 to 46, but that upgrade happens in their NPM toolchain and is unrelated to our update. We're fine to see this as non-breaking.Breaking-107063-CKEditor5-v46.rst:21Ack, upstream basically did the same as we did previously with https://review.typo3.org/c/Packages/TYPO3.CMS/+/89862 – but it applied it to all elements. The reason is dark mode as described in https://github.com/ckeditor/ckeditor5/issues/18710 I'd not see this as a blocker, since it is opiniated, yes, but it will not heavily break since everyone with custom stylings (that did not just wanted their fonts to look like default TYPO3 backend – which will not break) will overrule the new default anyway. This can be seen as non-breaking.Breaking-107063-CKEditor5-v46.rst:26This could be an Important.rst if we want to. We could also see if we could "hotfix" defined variables within `./Build/Sources/TypeScript/rte-ckeditor/css-prefixer.ts` and provide a automatic migration in v13/main, but that's probably out of scope? -
Garvin Hicking commented on patch set 9 09/23/25, 08:01
Reply
Thanks for writing this down. I agree and will rework the patch (likely on friday). I have no strong opinion about CSS on-the-fly migration, but I feel that could be flakey and much work for little gain. Advising to change custom CSS via important sounds more helpful to me to prevent side-effects and carrying around legacy migrations for a long time. -
Garvin Hicking marked it work in progress 09/23/25, 08:01
-
Garvin Hicking uploaded patch set 10
V +109/26/25, 06:35 -
Garvin Hicking marked it ready for review 09/26/25, 06:35
-
Garvin Hicking commented on patch set 10 09/26/25, 06:36
Reply
I've reworked the RST file and commit message, could you check if you find this reasonable?Breaking-107063-CKEditor5-v46.rst:16ReplyAcknowledgedBreaking-107063-CKEditor5-v46.rst:21ReplyAcknowledgedBreaking-107063-CKEditor5-v46.rst:26ReplyAcknowledged -
core-ci voted on patch set 10 V +1 09/26/25, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85567
-
Benjamin Franzke uploaded patch set 11
V +109/26/25, 07:25 -
Benjamin Franzke commented on patch set 11 09/26/25, 07:26
Reply
I only added minor clarifications that only type imports changed. Good to go now :) Thanks a bunch! -
core-ci voted on patch set 11 V +1 09/26/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85574
-
Andreas Kienast commented on patch set 11 09/30/25, 05:48
Important-107063-CKEditor5-v46.rst:36One minor note: we could use an actual diff here which makes it easier to see the actual changes. Opinions? -
Andreas Kienast commented on patch set 11 09/30/25, 05:50
CKEditor5Migrator.php:923```suggestion // CKEditor 4 used `wordcount` (lowercase), which is `wordCount` in CKEditor 5. ``` -
Garvin Hicking uploaded patch set 12
CR +1V +109/30/25, 06:54 -
Garvin Hicking commented on patch set 12 09/30/25, 06:55
Important-107063-CKEditor5-v46.rst:36ReplyGood point. Made it multiline, and I like it.CKEditor5Migrator.php:923ReplyHehe. Alright, unified that, too. :) -
core-ci voted on patch set 12 V +1 09/30/25, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85730
-
Simon Schaufelberger voted on patch set 12 CR +1 V +1 10/01/25, 19:25
-
Benjamin Franzke voted on patch set 12 CR +1 V +1 10/02/25, 08:59
-
Garvin Hicking voted on patch set 12 CR +2 V +2 10/02/25, 10:50
-
Garvin Hicking merged patch set 13 10/02/25, 11:34
Breaking-107063-CKEditor5-v46.rst:6