Review main Merged

90034[TASK] Add url type to settings API

Benjamin Kott CR +2 V +2 Normal +148 −0 updated 07/24/25, 12:06

Commit message

The new url type for the Settings API implements URL validation
to ensure users enter valid URLs for specific settings, while displaying
the raw URL in the field.

This provides confidence that URLs are properly formatted without
manual validation.

Usage Example:

settings:
  my_sitepackage.url:
    label: Url
    category: my_sitepackage
    type: url
    default: ''

  my_sitepackage.url_pattern:
    label: Url Pattern
    category: my_sitepackage
    type: url
    default: ''
    options:
      pattern: https://.*

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3664

Show 2039 earlier messages
  1. Benjamin Kott uploaded patch set 1 07/09/25, 11:21

  2. core-ci voted on patch set 1 V -1 07/09/25, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81524

  3. Benjamin Kott uploaded patch set 2 V -1 07/10/25, 14:49

  4. Benjamin Kott uploaded patch set 3 07/10/25, 14:49

  5. Benjamin Kott uploaded patch set 4 07/10/25, 14:53

  6. Benjamin Kott uploaded patch set 5 07/10/25, 14:57

  7. core-ci voted on patch set 2 V -1 07/10/25, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81564

  8. core-ci voted on patch set 3 V -1 07/10/25, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81565

  9. core-ci voted on patch set 4 V -1 07/10/25, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81567

  10. core-ci voted on patch set 5 V -1 07/10/25, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81570

  11. Benjamin Kott uploaded patch set 6 V -1 07/11/25, 06:32

  12. core-ci voted on patch set 6 V -1 07/11/25, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81600

  13. Benjamin Kott uploaded patch set 7 V -1 07/11/25, 06:46

  14. Benjamin Kott uploaded patch set 8 07/11/25, 06:51

  15. core-ci voted on patch set 7 V -1 07/11/25, 06:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81601

  16. core-ci voted on patch set 8 V +1 07/11/25, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81602

  17. Benjamin Kott uploaded patch set 9 V +1 07/11/25, 07:19

  18. core-ci voted on patch set 9 V +1 07/11/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81603

  19. Benjamin Kott uploaded patch set 10 V +1 07/14/25, 09:39

  20. core-ci voted on patch set 10 V -1 07/14/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81677

  21. Benjamin Franzke uploaded patch set 11 V -1 07/14/25, 11:03

  22. Benjamin Franzke uploaded patch set 12 07/14/25, 11:10

  23. Benjamin Franzke uploaded patch set 13 07/14/25, 11:11

  24. core-ci voted on patch set 11 V -1 07/14/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81678

  25. core-ci voted on patch set 12 V -1 07/14/25, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81680

  26. core-ci voted on patch set 13 V -1 07/14/25, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81682

  27. Benjamin Franzke uploaded patch set 14 V -1 07/14/25, 12:52

  28. core-ci voted on patch set 14 V -1 07/14/25, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81686

  29. Benjamin Kott uploaded patch set 15 V -1 07/14/25, 13:46

  30. core-ci voted on patch set 15 V -1 07/14/25, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81691

  31. Benjamin Franzke uploaded patch set 16 V -1 07/14/25, 15:48

  32. core-ci voted on patch set 16 V -1 07/14/25, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81694

  33. Benjamin Franzke uploaded patch set 17 V -1 07/14/25, 16:03

  34. core-ci voted on patch set 17 V +1 07/14/25, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81695

  35. Benjamin Franzke uploaded patch set 18 V +1 07/15/25, 08:44

  36. core-ci voted on patch set 18 V +1 07/15/25, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81727

  37. Benjamin Franzke uploaded patch set 19 V +1 07/15/25, 09:06

  38. core-ci voted on patch set 19 V +1 07/15/25, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81728

  39. Benjamin Franzke uploaded patch set 20 V +1 07/15/25, 09:33

  1. core-ci voted on patch set 20 V +1 07/15/25, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81729

  2. Benjamin Kott rebased onto patch set 21 V +1 07/15/25, 13:55

  3. core-ci voted on patch set 21 V +1 07/15/25, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81739

  4. Benjamin Franzke uploaded patch set 22 V +1 07/16/25, 06:53

  5. core-ci voted on patch set 22 V +1 07/16/25, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81767

  6. Benjamin Franzke uploaded patch set 23 V +1 07/17/25, 12:13

  7. core-ci voted on patch set 23 V +1 07/17/25, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81848

  8. Benni Mack uploaded patch set 24 V +1 07/23/25, 13:44

  9. core-ci voted on patch set 24 V -1 07/23/25, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82184

  10. Benni Mack updated the commit message in patch set 25 V -1 07/23/25, 13:49

  11. core-ci voted on patch set 25 V -1 07/23/25, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82186

  12. Garvin Hicking commented on patch set 25 07/23/25, 14:17

    url.ts:30

    does this also need the "required" attribute as with the settings api patch that introduced the max/min/step keys?
  13. Benni Mack rebased onto patch set 26 V -1 07/24/25, 05:00

  14. core-ci voted on patch set 26 V -1 07/24/25, 05:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82211

  15. Benjamin Franzke commented on patch set 26 07/24/25, 06:16

    url.ts:30 Reply

    no, this is more comparable to type `string` which allows an empty string, therefore `required` is not needed here. (`required` was used for type=number to ensure that a number instead of an empty field is submitted)
  16. Garvin Hicking commented on patch set 26 07/24/25, 06:29

    url.ts:30 Reply

    Should this type get a "required" option then maybe to force setting a valid URL?
  17. Benjamin Franzke uploaded patch set 27 V -1 07/24/25, 06:29

  18. core-ci voted on patch set 27 V +1 07/24/25, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82215

  19. Benni Mack updated the commit message in patch set 28 V +1 07/24/25, 09:49

  20. core-ci voted on patch set 28 V +1 07/24/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82229

  21. Benjamin Franzke voted on patch set 28 CR +1 V +1 07/24/25, 11:10

  22. Benjamin Franzke commented on patch set 28 07/24/25, 11:57

    url.ts:30 Reply

    ah, I see (unresolving), my opinion is: I don't think we need a required-option to disallow `''` as an empty value. Settings are coming from a set (or for future system settings from an installed extension), which does not have something like a creation wizard, where we could enforce that values need to be filled. We expect that a set can be applied on a site and works. Of course, denying `''` would be solvable by supplying a non-empty default – but I guess when a URL is really required, there is often no possibility to provide a sensible URL-default that is not `''`. WDYT?
  23. Garvin Hicking commented on patch set 28 CR +1 V +1 07/24/25, 12:02

    url.ts:30 Reply

    Thanks, I see your point, YNGNI. Let's do it without for now, and if we ever come across a real-world need for this we can still address it.
  24. Benni Mack voted on patch set 28 CR +2 V +2 07/24/25, 12:06

  25. Benni Mack merged patch set 29 07/24/25, 12:06