Review 13.4 Merged

90036[TASK] Simplify workspaces StagesService

Christian Kuhn CR +2 V +2 Hard +66 −251 updated 07/09/25, 13:10

Commit message

Yet another step to disentangle internal workspace classes:

* Refactor getWorkspaceId() away
* Remove unused getNextStages(), getPrevStages(), isValid()
* Simplify signature of getPreviousStageForElementCollection()
  and getNextStageForElementCollection()
* Inline single use of TABLE_STAGE constant
* Inline inconsistently used property $pathToLocallang
* Remove unused FE related label_nextStage, label_prevStage,
  path_Live and languageValue. This reduces DB load, especially
  when custom workspace stages are involed.
* Straighten StageRecord and WorkspaceRecord

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/09/25, 12:11

  2. core-ci voted on patch set 1 V +1 07/09/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81527

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 07/09/25, 13:10

  4. Christian Kuhn merged patch set 2 07/09/25, 13:10