Review main Merged

90038[TASK] Simplify workspaces PreviewController

Christian Kuhn CR +2 V +2 Normal +21 −38 updated 07/10/25, 09:23

Commit message

The workspaces "split" preview renders the "initial" stage
change buttons server side, and updates them with an ajax
call when stages are changed or changes are discarded.
This leads to duplicate code: PreviewController and the
ajax call do the same thing. The patch simplifies this by
not delivering available stages up front, but fetches the
buttons via ajax directly after load. The call is quite
quick - much quicker than rendering the page itself, so
it does not harm usability.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 710

  1. Christian Kuhn uploaded patch set 1 07/09/25, 17:49

  2. core-ci voted on patch set 1 V +1 07/09/25, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81534

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/09/25, 18:19

  4. core-ci voted on patch set 2 V +1 07/09/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81535

  5. Christian Kuhn rebased onto patch set 3 V +1 07/09/25, 18:28

  6. core-ci voted on patch set 3 V +1 07/09/25, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81536

  7. Benni Mack voted on patch set 3 CR +1 V +1 07/10/25, 08:27

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 07/10/25, 08:43

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 07/10/25, 09:18

  10. Christian Kuhn merged patch set 4 07/10/25, 09:23