Review main Merged

90043[TASK] Allow using CKEditor in fullscreen mode

Andreas Kienast CR +2 V +2 Hard +265 −88 updated 07/14/25, 07:02

Commit message

The CKEditor used in the TYPO3 backend now utilizes its "Fullscreen"
plugin [1], allowing to open CKEditor in a fullscreen view. To allow
editors to reach important actions nevertheless, the module's document
header will stay visible.

The CKEditor module `@ckeditor/ckeditor5-fullscreen` is installed to
enable toggling the fullscreen view in CKEditor.

The module is enabled by default in the `Full.yaml` preset, acting as a
"show off" configuration that should not be used in production.

To enable the module, the toolbar item `fullscreen` needs to be added.

Executed command:

    npm install --save @ckeditor/ckeditor5-fullscreen@^45.2.1
    npm run build

[1] https://ckeditor.com/docs/ckeditor5/latest/features/fullscreen.html

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 87

Show 67 more files

Review log 1725

  1. Andreas Kienast uploaded patch set 1 07/10/25, 10:27

  2. Andreas Kienast uploaded patch set 2 07/10/25, 10:30

  3. core-ci voted on patch set 1 V +1 07/10/25, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81552

  4. core-ci voted on patch set 2 V +1 07/10/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81553

  5. Andreas Kienast uploaded patch set 3 V +1 07/10/25, 12:38

  6. core-ci voted on patch set 3 V +1 07/10/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81561

  7. Andreas Kienast uploaded patch set 4 V +1 07/10/25, 13:25

  8. core-ci voted on patch set 4 V +1 07/10/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81562

  9. Andreas Kienast commented on patch set 4 CR -2 07/10/25, 13:39

    Not sure if this should go into v13 as well, while the plugin will be disabled by default.
  10. Andreas Kienast uploaded patch set 5 V +1 07/11/25, 05:46

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  11. Andreas Kienast voted on patch set 5 CR 0 07/11/25, 05:46

  12. Andreas Kienast commented on patch set 5 07/11/25, 05:47

    Reply

    Done
  13. core-ci voted on patch set 5 V +1 07/11/25, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81596

  14. Andreas Kienast uploaded patch set 6 V +1 07/11/25, 06:11

  15. Andreas Kienast commented on patch set 6 V -1 07/11/25, 06:14

    There's a conflict – the menu bar shows options that are not rendered in the RTE itself (headings can be added to SysNews). Also, there are still some colors off.
  16. core-ci voted on patch set 6 V +1 07/11/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81598

  17. Andreas Kienast uploaded patch set 7 V +1 07/11/25, 06:32

  18. Andreas Kienast commented on patch set 7 07/11/25, 06:32

    Reply

    Done
  19. core-ci voted on patch set 7 V +1 07/11/25, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81599

  20. Andreas Kienast uploaded patch set 8 V +1 07/11/25, 07:51

  21. core-ci voted on patch set 8 V +1 07/11/25, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81605

  22. Andreas Nedbal voted on patch set 8 CR +1 V +1 07/11/25, 08:25

  23. Garvin Hicking voted on patch set 8 CR +1 V +1 07/11/25, 09:10

  24. Andreas Kienast voted on patch set 8 CR +2 V +2 07/14/25, 06:41

  25. Andreas Kienast merged patch set 9 07/14/25, 07:02