Review main Merged

90045[TASK] Rename fieldExplanationText to description

Josua Vogel CR +2 V +2 Hard +604 −374 updated 02/09/26, 17:50

Commit message

The hard-to-grasp configuration fieldExplanationText was renamed to description.
In addition the possibility to define a fieldExplanationText for the
Inspector components SingleSelect, MultiSelect and CountrySelect has been added.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 141

Show 121 more files

Review log 3346

Show 1621 earlier messages
  1. Josua Vogel uploaded patch set 1 07/10/25, 11:56

  2. core-ci voted on patch set 1 V +1 07/10/25, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81558

  3. Benjamin Kott uploaded patch set 2 V +1 08/14/25, 08:50

  4. Benjamin Kott commented on patch set 2 CR -1 08/14/25, 08:56

    - this patch is more a bugfix just to ensure fields are behaving the same - that also means the documentation needs to be updated for all these fields - i also think that "updating" the field is not correct here because its more like part of a rendering so i think "render" would be a more fitting description here. - we have the same issue with the label but we should think about unify the rendering here also, just to get a better overview what's happening here. - "fieldExplanationText" is more like a field description / help text again a hard to grasp name when you are not into the rendering, sadly this cannot be changed as a bugfix and ported back to 13.4 but could be something we adjust breaking in 14 / main
  5. core-ci voted on patch set 2 V +1 08/14/25, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83364

  6. Josua Vogel uploaded patch set 3 CR -1 V +1 09/29/25, 14:34

  7. Josua Vogel uploaded patch set 4 09/29/25, 14:39

  8. core-ci voted on patch set 3 V +1 09/29/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85694

  9. Josua Vogel commented on patch set 4 09/29/25, 14:42

    Reply

    changed everything, except the point "unify rendering of the label". I would see this as separate task
  10. Josua Vogel commented on patch set 4 09/29/25, 14:44

    changelog entry will be added soon
  11. core-ci voted on patch set 4 V +1 09/29/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85695

  12. Georg Ringer commented on patch set 4 09/30/25, 06:17

    please add a breaking rst, thanks!
  13. Josua Vogel uploaded patch set 5 V +1 09/30/25, 06:39

  14. Josua Vogel commented on patch set 4 09/30/25, 06:40

    Reply

    done
  15. core-ci voted on patch set 5 V +1 09/30/25, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85728

  16. Sven Liebert voted on patch set 5 CR +1 V +1 10/23/25, 16:53

  17. Garvin Hicking commented on patch set 5 10/24/25, 10:48

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33

    We should mention that dual-version compatibility (v13+v14) would probably need to have custom elements define BOTH fieldExplanationText AND description?
  18. Josua Vogel commented on patch set 5 10/24/25, 14:02

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    I don't think it's very nice to support both. @benjamin.kott@outlook.com what´s your opinion?
  19. Simon Schaufelberger commented on patch set 5 11/07/25, 17:09

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    ping
  20. Josua Vogel commented on patch set 5 11/07/25, 21:45

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    well in my opinion we should replace fieldExplanationText and don’t support both. This change would in addition be more close to TCA - no special keywords, just „description“
  21. Garvin Hicking commented on patch set 5 11/08/25, 05:51

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    I still think its not cool to have yaml forms with both keys and feel that renaming the field has more drawbacks than benefits. I'm not blocking though, so if there are enough votes I'm ok!
  1. Benjamin Kott commented on patch set 5 11/22/25, 18:44

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    i think we can migrate it so old version can support v13 and v14 by having only fieldExplanationText but description is preferred and fieldExplanationText is migrated during the loading process, i am giving it a look now
  2. Benjamin Kott uploaded patch set 6 CR +1 V +1 11/22/25, 21:03

  3. Benjamin Kott commented on patch set 6 11/22/25, 21:14

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    So, I´ve added a migration so we do not need to be breaking - i think that´s the best option. Anyways i still do not like the structure here also because we are handling a loose array and have not a "good" place to add the migration. We should think about this carefully.
  4. core-ci voted on patch set 6 V -1 11/22/25, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90692

  5. Josua Vogel uploaded patch set 7 V -1 11/25/25, 15:42

  6. core-ci voted on patch set 7 V +1 11/25/25, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90961

  7. Garvin Hicking commented on patch set 7 11/25/25, 16:39

    Breaking-107068-RenameFieldExplanationTextToDescription.rst:33 Reply

    I'm resolving my comment. I think the new approach is more convenient and a good improvement (thanks!), but my $0.02 is still that I think the benefit of renaming is too slim for the work it causes. I am fine with this getting approval though!
  8. Josua Vogel uploaded patch set 8 V +1 01/20/26, 14:04

  9. Josua Vogel uploaded patch set 9 01/20/26, 14:06

  10. Josua Vogel uploaded patch set 10 01/20/26, 14:08

  11. core-ci voted on patch set 8 V +1 01/20/26, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93868

  12. core-ci voted on patch set 9 V +1 01/20/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93869

  13. core-ci voted on patch set 10 V +1 01/20/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93870

  14. Sven Liebert voted on patch set 10 CR +1 V +1 01/21/26, 14:25

  15. Georg Ringer voted on patch set 10 CR +1 V +1 02/06/26, 19:14

  16. Josua Vogel uploaded patch set 11 CR +1 V +1 02/06/26, 19:20

  17. Sven Liebert voted on patch set 11 CR +1 V +1 02/06/26, 19:24

  18. core-ci voted on patch set 11 V -1 02/06/26, 19:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95338

  19. Josua Vogel rebased onto patch set 12 CR +1 V +1 02/06/26, 19:40

  20. core-ci voted on patch set 11 V +1 02/06/26, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95338

  21. core-ci voted on patch set 12 V +1 02/06/26, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95340

  22. Georg Ringer voted on patch set 12 CR +1 V +1 02/06/26, 20:02

  23. Sven Liebert voted on patch set 12 CR +1 V +1 02/06/26, 20:18

  24. Georg Ringer voted on patch set 12 CR +2 V +2 02/09/26, 17:50

  25. Georg Ringer merged patch set 13 02/09/26, 17:50