Review main Abandoned

90047[BUGFIX] PropertyGridEditor respects shouldShowPreselectedValueColumn

Josua Vogel CR -1 V 0 Easy +9 −9 updated 08/14/25, 11:40

Commit message

If the shouldShowPreselectedValueColumn option is set, the selection
column is shown or hidden in the PropertyGridEditor.

The column is hidden by default to ensure compatibility.
In addition, the option has been changed from data type string to a boolean.

Review

  • Code review CR -1
    • Benjamin Kott -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 7

Review log 58

  1. Josua Vogel uploaded patch set 1 07/10/25, 12:34

  2. core-ci voted on patch set 1 V +1 07/10/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81560

  3. Benjamin Kott uploaded patch set 2 V +1 08/13/25, 07:36

  4. core-ci voted on patch set 2 V +1 08/13/25, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83273

  5. Oliver Klee updated the commit message in patch set 3 V +1 08/13/25, 09:58

  6. core-ci voted on patch set 3 V +1 08/13/25, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83290

  7. Benjamin Kott commented on patch set 3 CR -1 08/14/25, 08:38

    - documentation is still showing the "string" options - the option name is confusing and hard to grasp what it does, its only relevant if the field is used to render checkboxes, radios or selects. for all others this is not relevant. see finisher configs (email) - we cannot change the config type for backports this needs to be breaking and moved only towards v14 - as we need to be breaking anyways here, the question is if we find a better name here to better relect the action that is performed.
  8. Benjamin Kott abandoned the change 08/14/25, 11:40

    We will drop the option here as it was unused before, see issue for workaround and current working implementation.