90048[BUGFIX] Optimize queries in RootlineUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1925
-
Benni Mack uploaded patch set 1 07/10/25, 14:51
-
Christian Kuhn commented on patch set 1 CR -1 07/10/25, 14:53
will review & fine-tune soon. -
Benni Mack uploaded patch set 2
CR -107/10/25, 14:53 -
core-ci voted on patch set 1 V +1 07/10/25, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81566
-
core-ci voted on patch set 2 V +1 07/10/25, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81569
-
Andreas Kienast commented on patch set 2 07/11/25, 09:52
RootlineUtility.php:1417From my understanding: this cache is only filled if the schema cache `pages-fields` is considered invalid. Once something valid is available, this runtime cache is always empty. Isn't this additional cache layer superfluous then? Shouldn't the runtime cache be filled anytime (by moving this call outside the `if()`)? -
Benni Mack uploaded patch set 3
V +107/11/25, 11:18 -
core-ci voted on patch set 3 V +1 07/11/25, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81610
-
Andreas Kienast commented on patch set 3 07/11/25, 11:44
RootlineUtility.php:1417ReplyDone -
Benni Mack marked it work in progress 07/11/25, 15:58
-
Christian Kuhn commented on patch set 3 07/11/25, 23:41
RootlineUtility.php:1406it looks to me as if we should use Core\Database\Schema\SchemaInformation->introspectTable() (which does the caching in filesystem internally), to then store the getColumns result into "our" runtimeCache. -
Benni Mack uploaded patch set 4
V +107/15/25, 07:17 -
core-ci voted on patch set 4 V +1 07/15/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81721
-
Benjamin Franzke commented on patch set 4 07/23/25, 08:35
The database `SchemaInformation` uses a file-cache `database_schema` https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Database/Connection.php#L440-L446 https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Configuration/DefaultConfiguration.php#L256-L258 Are we sure this statement is actually true or maybe a system (mis)configuration issue? The introspection is meant to be done once and cached afterwards. (but I definitely see room for improvement there, it should be hookued up to the `CacheWarmupEvent`) -
Benni Mack uploaded patch set 5
V +107/23/25, 13:55 -
Benni Mack commented on patch set 5 07/23/25, 13:56
RootlineUtility.php:1406ReplyDone -
core-ci voted on patch set 5 V +1 07/23/25, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82187
-
Benni Mack updated the commit message in patch set 6
V +107/25/25, 19:34 -
Benni Mack marked it ready for review 07/25/25, 19:34
-
core-ci voted on patch set 6 V +1 07/25/25, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82332
-
Benni Mack commented on patch set 6 07/28/25, 06:23
Reply
debugged this - that was not the underlying root cause. -
Stefan Bürk voted on patch set 6 CR +1 V +1 07/28/25, 16:15
-
Christian Kuhn commented on patch set 6 CR +1 V +1 07/28/25, 17:49
Reply
Done -
Benni Mack voted on patch set 6 CR +2 V +2 07/29/25, 17:58
-
Benni Mack merged patch set 7 07/29/25, 17:58