Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90049[FEATURE] Enhance slug generation for folders and spacers
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/49/90049/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/49/90049/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+7 −2
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php1+18 −0
- typo3/sysext/core/Configuration/TCA/pages.php+1 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-107069-SuffixForNonBrowsableDoctypes.rstnew+39 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+107 −3
Review log 1622
-
anonymized-98012 uploaded patch set 1 07/10/25, 14:53
-
core-ci voted on patch set 1 V -1 07/10/25, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81568
-
anonymized-98012 uploaded patch set 2
V -107/11/25, 05:56 -
core-ci voted on patch set 2 V +1 07/11/25, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81597
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/17/25, 15:38
-
Benni Mack commented on patch set 2 08/13/25, 17:18
hey marc, one other idea floating around since a few versions is to allow empty slugs for non-linkable doctypes. wdyt? -
Wolfgang Klinger commented on patch set 2 12/18/25, 17:13
Reply
I think that's the far better idea (configurable). -
Oliver Klee voted on patch set 2 V +1 12/18/25, 21:45
-
Simon Schaufelberger uploaded patch set 3
CR +1V +102/12/26, 21:14 -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/12/26, 21:14
-
core-ci voted on patch set 3 V -1 02/12/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95781
-
Simon Schaufelberger voted on patch set 3 CR 0 V 0 02/12/26, 22:02
-
Simon Schaufelberger uploaded patch set 4
V -102/13/26, 21:26 -
core-ci voted on patch set 4 V +1 02/13/26, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95850
-
Simon Schaufelberger uploaded patch set 5
V +102/13/26, 22:14 -
core-ci voted on patch set 5 V -1 02/13/26, 22:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95851
-
Simon Schaufelberger uploaded patch set 6
V -102/13/26, 22:18 -
Simon Schaufelberger voted on patch set 6 CR +1 V +1 02/13/26, 22:19
-
core-ci voted on patch set 6 V +1 02/13/26, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95852
-
Benni Mack commented on patch set 6 02/14/26, 20:43
Reply
we now have non-viewable doktypes that is configurable since v14. We could now finally implement the possibility to also skip slug generation for such. Nonetheless this option can be included as well as is, which is totally legit as well IMHO. -
Benni Mack wrote 04/21/26, 14:52
Removed cc Benni Mack. -
Alexander Stehlik commented on patch set 6 05/26/26, 18:59
SlugHelper.php:236UnresolvedDoes it make sense to add the suffix as a parameter here?