Review main Merged

90050[BUGFIX] Make CKEditor's "Powered by" badge context-aware

Andreas Kienast CR +2 V +2 Easy +14 −1 updated 07/14/25, 12:00

Commit message

Since #106964, CKEditor is context-aware by default. This has the
negative side-effect that the "Powered by" badge in CKEditor, that is
rendered on focus in the bottom right corner, looks disturbing in dark
mode.

This patch adjusts some CSS properties and the logo's `fill` property,
which is allowed by CKEditor and also documented at [1].

[1] https://ckeditor.com/docs/ckeditor5/latest/getting-started/licensing/managing-ckeditor-logo.html

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1214

  1. Andreas Kienast uploaded patch set 1 07/11/25, 07:48

  2. core-ci voted on patch set 1 V +1 07/11/25, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81604

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 07/11/25, 08:21

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/11/25, 08:53

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 07/11/25, 09:22

  6. Andreas Kienast commented on patch set 1 CR -2 07/11/25, 09:29

    Will merge this after https://review.typo3.org/c/Packages/TYPO3.CMS/+/90043 is in to avoid rebasing foo.
  7. Andreas Kienast uploaded patch set 2 CR +1 V +1 07/14/25, 07:04

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Andreas Kienast voted on patch set 2 CR 0 07/14/25, 07:04

  9. core-ci voted on patch set 2 V +1 07/14/25, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81676

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 07/14/25, 07:24

  11. Andreas Nedbal voted on patch set 2 CR +1 V +1 07/14/25, 11:21

  12. Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/14/25, 11:37

  13. Andreas Kienast voted on patch set 2 CR +2 V +2 07/14/25, 11:45

  14. Andreas Kienast merged patch set 3 07/14/25, 12:00