Review main Merged

90052[BUGFIX] Improve workspace stagechg_notification

Christian Kuhn CR +2 V +2 Easy +8 −17 updated 07/11/25, 16:36

Commit message

sys_workspace records have a select drop down with three
options to globally determine if notifications upon stage
changes of workspace records are sent.

There is no difference in its handling between state 1
and 10. The patch turns the select into an on/off toggle
and improves labeling and description.

Note, if disabled, this checkbox technically obsoletes the
'show dialog' checkbox setting available for single stages,
which in turn influences the "Allow to change pre-selection
of recipients" checkbox. We'll improve wording of them with
another change to hint about relations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Christian Kuhn uploaded patch set 1 07/11/25, 11:15

  2. core-ci voted on patch set 1 V +1 07/11/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81609

  3. Jasmina Ließmann voted on patch set 1 CR +1 V +1 07/11/25, 11:35

  4. Benni Mack voted on patch set 1 CR +2 07/11/25, 13:01

  5. Benni Mack voted on patch set 1 V +2 07/11/25, 13:01

  6. Oli Bartsch voted on patch set 1 CR +1 V +1 07/11/25, 16:09

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 07/11/25, 16:36

  8. Christian Kuhn merged patch set 2 07/11/25, 16:36