90058[FEATURE] Add options to predefine link target and class in LinkBrowser
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Jörg Bösche +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Michael Staatz uploaded patch set 1 07/13/25, 03:38
-
core-ci voted on patch set 1 V +1 07/13/25, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81647
-
Garvin Hicking commented on patch set 1 07/13/25, 09:55
Nice, thank you, this seems to work well for me. How do you feel about also allowing to pre-configure the "CSS" field? "Title" would always be individual (and was removed in the RTE config due to this) so I think that would be the only one missing?AbstractLinkBrowserController.php:227Should a global key like "RTE.buttons.link.properties.target.default" does for the RTE also made available, so that one would not need to individually set each key?Feature-107081-AddAnOptionToPredefineLinkTargetInLinkBrowser.rst:19```suggestion Configuration can be set via Page TSconfig: ```Feature-107081-AddAnOptionToPredefineLinkTargetInLinkBrowser.rst:38How about adding a paragraph like: ``` .. hint:: Note that default `target` attributes of links added via the RTE are configured individually via Page TSConfig options like: .. code-block:: typoscript RTE.buttons.link.properties.target.default = _blank RTE.buttons.link.page.properties.target.default = _blank ``` For details, see `buttons.link.[ type ].properties.target.default <https://docs.typo3.org/permalink/t3tsref:buttons-link-type-properties-target-default>`_. -
Michael Staatz commented on patch set 1 07/13/25, 12:42
Reply
Nice Idea. I will get in to this and also the global key. -
Michael Staatz updated the commit message in patch set 2
V +107/13/25, 14:52 -
Michael Staatz uploaded patch set 3 07/13/25, 14:55
-
core-ci voted on patch set 2 V +1 07/13/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81658
-
core-ci voted on patch set 3 V +1 07/13/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81659
-
Garvin Hicking commented on patch set 3 07/14/25, 18:20
AbstractLinkBrowserController.php:227ReplyDoneAbstractLinkBrowserController.php:260Fingers crossed nobody named their linkhandler "properties". I think "claiming" it for consistency is still fair at this point and aligns with the "RTE.buttons.link.properties" naming scheme.Feature-107081-AddAnOptionToPredefineLinkTargetInLinkBrowser.rst:19ReplyDoneFeature-107081-AddAnOptionToPredefineLinkTargetInLinkBrowser.rst:38ReplyDoneFeature-107081-AddOptionsToPredefineLinkTargetAndClassInLinkBrowser.rst:21```suggestion TCEMAIN.linkHandler.[handlerKey].(target|cssClass).default = _blank ``` -
Michael Staatz commented on patch set 3 07/14/25, 18:47
Feature-107081-AddOptionsToPredefineLinkTargetAndClassInLinkBrowser.rst:21ReplyFix applied. -
Michael Staatz commented on patch set 3 07/14/25, 18:53
AbstractLinkBrowserController.php:260ReplyDid it mean it should be changed? Or does it need an other default key? May be it could be "TCEMAIN.linkhandlers.properties.(target|cssClass).default" ? -
Michael Staatz commented on patch set 4
V +107/14/25, 18:55Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 CR +1 V +1 07/14/25, 18:58
AbstractLinkBrowserController.php:260ReplyHonestly I think it's OK to use that key, just wanted to take note why I believe it's fair. Your idea to take the plural-s variant for its own key might be a compromise, let's see what other's say. I think it could also lead to confusing key names or typos if that small distinction is made. -
core-ci voted on patch set 4 V +1 07/14/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81701
-
Jörg Bösche voted on patch set 4 CR +1 08/18/25, 11:26
-
Oli Bartsch voted on patch set 4 CR +1 V +1 09/18/25, 21:03
-
Garvin Hicking voted on patch set 4 CR +2 V +2 09/18/25, 21:06
-
Garvin Hicking merged patch set 5 09/18/25, 21:07
-
Lina Wolf commented on patch set 5 11/01/25, 09:43
Unresolved
Please review Documentation: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/pull/1647