90063[TASK] Structure input/label to Bootstrap suggestion
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 8
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml+3 −3
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+3 −3
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Field.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/AdvancedPassword.html+0 −8
- typo3/sysext/form/Resources/Private/Frontend/Partials/Checkbox.html+3 −3
- typo3/sysext/form/Resources/Private/Frontend/Partials/MultiCheckbox.html+23 −35
- typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html+22 −34
Review log 1014
-
Josua Vogel uploaded patch set 1 07/14/25, 12:42
-
Mathias Brodala updated the commit message in patch set 2 07/14/25, 12:49
-
core-ci voted on patch set 1 V +1 07/14/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81684
-
Mathias Brodala commented on patch set 2 07/14/25, 12:51
Reworded to make it clear that there is nothing wrong with the current structure per-se, as it is valid HTML. But BS expects the verbose variant. Also this can only be backported to v13 since v12 will only get security fixes. -
Josua Vogel commented on patch set 2 07/14/25, 12:57
Reply
thx! -
core-ci voted on patch set 2 V +1 07/14/25, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81685
-
Garvin Hicking commented on patch set 2 07/14/25, 14:40
Could you update the commit message to explain why several validationErrors checks and outputs are removed/changed? -
Josua Vogel updated the commit message in patch set 3
V +107/14/25, 14:51 -
Josua Vogel commented on patch set 3 07/14/25, 14:52
Reply
Done -
core-ci voted on patch set 3 V +1 07/14/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81693
-
Benjamin Kott commented on patch set 3 CR -1 08/14/25, 08:59
we cannot backport this change to v13, it highly affects the rendering and we are too late in the cycle to let it slip. in general i dislike the current rendering and we should rethink how we provide renderings here especially for the frontend. the backend rendering needs to be decoupled and should never affect the frontend rendering. we need a better plan to proceed here and also tackle this until v14 to allow a breaking change here. -
Benni Mack updated the commit message in patch set 4
CR -1V +104/22/26, 06:33 -
core-ci voted on patch set 4 V -1 04/22/26, 07:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100731
-
Josua Vogel abandoned the change 05/22/26, 12:07