Review main Abandoned

90063[TASK] Structure input/label to Bootstrap suggestion

Josua Vogel CR 0 V -1 Normal +58 −90 updated 05/22/26, 12:07

Commit message

According to Bootstrap 5 documentation, the expected approach
is to place <input> and <label> as sibling elements, using matching id
and for attributes to link them.

This fix restructures the relevant partials to follow the
recommended markup.

In addition, the validationErrors handling has been simplified, as the code between the Field partial and the individual elements,that render a fieldset, is the same.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 8

Review log 1014

  1. Josua Vogel uploaded patch set 1 07/14/25, 12:42

  2. Mathias Brodala updated the commit message in patch set 2 07/14/25, 12:49

  3. core-ci voted on patch set 1 V +1 07/14/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81684

  4. Mathias Brodala commented on patch set 2 07/14/25, 12:51

    Reworded to make it clear that there is nothing wrong with the current structure per-se, as it is valid HTML. But BS expects the verbose variant. Also this can only be backported to v13 since v12 will only get security fixes.
  5. Josua Vogel commented on patch set 2 07/14/25, 12:57

    Reply

    thx!
  6. core-ci voted on patch set 2 V +1 07/14/25, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81685

  7. Garvin Hicking commented on patch set 2 07/14/25, 14:40

    Could you update the commit message to explain why several validationErrors checks and outputs are removed/changed?
  8. Josua Vogel updated the commit message in patch set 3 V +1 07/14/25, 14:51

  9. Josua Vogel commented on patch set 3 07/14/25, 14:52

    Reply

    Done
  10. core-ci voted on patch set 3 V +1 07/14/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81693

  11. Benjamin Kott commented on patch set 3 CR -1 08/14/25, 08:59

    we cannot backport this change to v13, it highly affects the rendering and we are too late in the cycle to let it slip. in general i dislike the current rendering and we should rethink how we provide renderings here especially for the frontend. the backend rendering needs to be decoupled and should never affect the frontend rendering. we need a better plan to proceed here and also tackle this until v14 to allow a breaking change here.
  12. Benni Mack updated the commit message in patch set 4 CR -1 V +1 04/22/26, 06:33

  13. core-ci voted on patch set 4 V -1 04/22/26, 07:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100731

  14. Josua Vogel abandoned the change 05/22/26, 12:07