90064[TASK] Avoid deleting the settings.yaml file from a site folder
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Stefan Bürk +1
- Rozbeh Chiryai Sharahi +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Stefan Bürk +1
- Rozbeh Chiryai Sharahi +1
- core-ci +1 CI
Issues 1
Files 3
Review log 79
-
Benjamin Franzke uploaded patch set 1 07/14/25, 13:25
-
core-ci voted on patch set 1 V +1 07/14/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81689
-
Benjamin Franzke uploaded patch set 2
V +107/14/25, 13:33 -
core-ci voted on patch set 2 V +1 07/14/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81690
-
Rozbeh Chiryai Sharahi commented on patch set 2 CR +1 V +1 07/15/25, 18:23
I tested the changes on one of my projects. First I let the system run into the error: Yaml file ... does not contain data Afterwards applied the changes Finally tested again All tests were fine. BE settings GUI, Removing the last entry in settings, Loading the backend in general, Frontend, Frontend when settings are actually loaded and used while being completely empty => default-values. -
Stefan Bürk voted on patch set 2 CR +1 V +1 07/16/25, 06:02
-
Garvin Hicking voted on patch set 2 CR +1 V +1 07/16/25, 06:19
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 07/17/25, 07:32
-
Benjamin Franzke merged patch set 3 07/17/25, 09:19