Review main Merged

90064[TASK] Avoid deleting the settings.yaml file from a site folder

Benjamin Franzke CR +2 V +2 Easy +14 −7 updated 07/17/25, 09:19

Commit message

When resetting all settings to their default value via the settings
editor, an empty settings result map is to be persisted and a
site-specific custom settings.yaml becomes obsolete.

The current pragmatic approach to delete the settings.yaml file
worked for most cases, but we can not assume that a settings.yaml can
always be recreated as-is later on, when custom settings should be
stored again. The settings file might be symlinked, mounted or
associated with specific file system permissions, and should therefore
never be deleted.

To address these requirements the file contents are now only wiped,
without deleting the file itself.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Rozbeh Chiryai Sharahi +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Rozbeh Chiryai Sharahi +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benjamin Franzke uploaded patch set 1 07/14/25, 13:25

  2. core-ci voted on patch set 1 V +1 07/14/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81689

  3. Benjamin Franzke uploaded patch set 2 V +1 07/14/25, 13:33

  4. core-ci voted on patch set 2 V +1 07/14/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81690

  5. Rozbeh Chiryai Sharahi commented on patch set 2 CR +1 V +1 07/15/25, 18:23

    I tested the changes on one of my projects. First I let the system run into the error: Yaml file ... does not contain data Afterwards applied the changes Finally tested again All tests were fine. BE settings GUI, Removing the last entry in settings, Loading the backend in general, Frontend, Frontend when settings are actually loaded and used while being completely empty => default-values.
  6. Stefan Bürk voted on patch set 2 CR +1 V +1 07/16/25, 06:02

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 07/16/25, 06:19

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 07/17/25, 07:32

  9. Benjamin Franzke merged patch set 3 07/17/25, 09:19