Review main Merged

90072[BUGFIX] Ensure setting input fields do not lose focus on value change

Benjamin Franzke CR +2 V +2 Easy +18 −10 updated 07/15/25, 10:57

Commit message

Make sure that the settings specific type field is always
rendered and never temporarily replaced by a loading spinner,
which causes input focus to be lost when changing values via
keyboard (e.g. by pressing up or down in a `number` field).

Note: The respective rendering is triggered because the has-change
class was to be added, but caused this glitch as a side effect.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Benjamin Franzke uploaded patch set 1 07/15/25, 07:57

  2. Benjamin Franzke uploaded patch set 2 07/15/25, 07:59

  3. Benjamin Franzke updated the commit message in patch set 3 07/15/25, 08:03

  4. core-ci voted on patch set 1 V +1 07/15/25, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81722

  5. core-ci voted on patch set 2 V +1 07/15/25, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81723

  6. core-ci voted on patch set 3 V +1 07/15/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81724

  7. Benjamin Kott voted on patch set 3 CR +1 V +1 07/15/25, 08:21

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 07/15/25, 09:26

  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 07/15/25, 09:38

  10. Benjamin Franzke merged patch set 4 07/15/25, 10:57