Review main Merged

90076[BUGFIX] Remove only leading 'ajax_' prefix in Ajax route keys

TYPO3com CR +2 V +2 Easy +3 −1 updated 08/11/25, 08:43

Commit message

Previously, all occurrences of 'ajax_' were removed from AJAX route keys
in `TYPO3.settings.ajaxUrls`, leading to mismatches between PHP and JS
keys. Now, only a leading 'ajax_' prefix is stripped, preserving the
rest of the key.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1420

  1. TYPO3com uploaded patch set 1 07/16/25, 07:35

  2. core-ci voted on patch set 1 V +1 07/16/25, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81768

  3. Andreas Kienast commented on patch set 1 CR -1 07/16/25, 08:21

    on it

    PageRenderer.php:1534

    We can use `str_starts_with` instead.
  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 07/16/25, 08:52

  5. Andreas Kienast commented on patch set 2 07/16/25, 08:52

    PageRenderer.php:1534 Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/16/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81770

  7. Oli Bartsch updated the commit message in patch set 3 V +1 07/17/25, 07:43

  8. Oli Bartsch commented on patch set 3 CR +1 V +1 07/17/25, 07:43

    Thanks for the patch. I consider this a regular bugfix and suggest backporting it accordingly. Regarding your concern about developers relying on the current behavior: I believe the risk is relatively low. Moreover, if we avoided backporting any fix due to potential reliance on buggy behavior, we’d severely limit our ability to improve stability.
  9. Oli Bartsch updated the commit message in patch set 4 CR +1 V +1 07/17/25, 07:49

  10. Oli Bartsch commented on patch set 4 07/17/25, 07:50

    Reply

    Talk with Andy and reverted the changes. However, I still think this could be handled as regular bugfix.
  11. core-ci voted on patch set 3 V +1 07/17/25, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81814

  12. core-ci voted on patch set 4 V +1 07/17/25, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81815

  13. Henning Liebe commented on patch set 4 CR +1 08/07/25, 18:22

    looks good to me
  14. Stefan Bürk commented on patch set 4 08/11/25, 00:56

    Reply

    I would remove the "breaking" rst-file and `[!!!]` and make the bugfix main only. Developer hitted by the bug on the search for an fix can use composer patches to backport it and 14.0 fixes it. > It's not a bug it's a feature. Every bugfix is "breaking" if someone decided to take the "bug" as feature and for many bugfixes there is always at least one soul getting a breaking ... taking it as a casual bugfix for main only would lower it for all of them and limit the impact to an major version upgrade then.
  15. Oli Bartsch uploaded patch set 5 CR +1 V +1 08/11/25, 08:06

  16. Oli Bartsch voted on patch set 5 CR +1 V +1 08/11/25, 08:08

  17. core-ci voted on patch set 5 V +1 08/11/25, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83128

  18. Benni Mack voted on patch set 5 CR +1 V +1 08/11/25, 08:35

  19. Oli Bartsch voted on patch set 5 CR +2 V +2 08/11/25, 08:43

  20. Oli Bartsch merged patch set 6 08/11/25, 08:43