90081[FEATURE] Introduce expression for accessing site locale
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1217
-
Josua Vogel uploaded patch set 1 07/16/25, 17:55
-
core-ci voted on patch set 1 V +1 07/16/25, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81786
-
Chris Müller uploaded patch set 2
V +107/16/25, 18:27 -
core-ci voted on patch set 2 V +1 07/16/25, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81787
-
Simon Schaufelberger commented on patch set 2 07/17/25, 10:21
Feature-107105-IntroduceExpressionForAccessingSiteLocaleAsString.rst:28please use END instead. -
Garvin Hicking commented on patch set 2 07/17/25, 11:36
Typo3ConditionFunctionsProvider.php:140I am unsure if "posixFormatted" is the best way to return the locale. It will include suffixes like '.utf8', '.utf-8', '.UTF-8', '.utf8@euro' or similar, depending on the used system. That will make it hard for integrators to perform a check here? Maybe just querying the 'getName' variant with a return like 'de-DE' and 'en-US' would be better suited for comparison. I've pinged @benni@typo3.org to weigh in on this. -
Josua Vogel uploaded patch set 3
V +107/22/25, 08:29 -
Josua Vogel uploaded patch set 4 07/22/25, 08:30
-
Josua Vogel commented on patch set 4 07/22/25, 08:33
Typo3ConditionFunctionsProvider.php:137ReplyDoneTypo3ConditionFunctionsProvider.php:140ReplyDoneFeature-107105-IntroduceExpressionForAccessingSiteLocaleAsString.rst:28ReplyDone -
core-ci voted on patch set 3 V +1 07/22/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82098
-
core-ci voted on patch set 4 V +1 07/22/25, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82099
-
Josua Vogel uploaded patch set 5
V +107/22/25, 08:42 -
core-ci voted on patch set 5 V +1 07/22/25, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82101
-
Garvin Hicking voted on patch set 5 CR +1 V +1 07/22/25, 09:07
-
Benni Mack voted on patch set 5 CR +1 V +1 07/22/25, 10:59
-
Garvin Hicking voted on patch set 5 CR +2 V +2 07/22/25, 12:43
-
Garvin Hicking merged patch set 6 07/26/25, 19:22
Typo3ConditionFunctionsProvider.php:137