Review main Merged

90091[TASK] Update `phpstan/phpstan` to 2.1.18

Garvin Hicking CR +2 V +2 Easy +7 −7 updated 07/18/25, 14:36

Commit message

Executed commands:

    composer require --dev phpstan/phpstan:^2.1.18 -W

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1318

  1. Garvin Hicking uploaded patch set 1 07/18/25, 07:32

  2. core-ci voted on patch set 1 V -1 07/18/25, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81907

  3. Benjamin Franzke commented on patch set 1 07/18/25, 07:56

    8
  4. Garvin Hicking updated the commit message in patch set 2 V -1 07/18/25, 09:39

  5. Garvin Hicking commented on patch set 2 V -1 07/18/25, 09:39

    - Needs merge of https://review.typo3.org/c/Packages/TYPO3.CMS/+/90090 - Backport 12.4 needs a new baseline entry
  6. Garvin Hicking updated the commit message in patch set 3 V -1 07/18/25, 09:40

  7. core-ci voted on patch set 2 V -1 07/18/25, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81919

  8. core-ci voted on patch set 3 V -1 07/18/25, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81921

  9. Garvin Hicking rebased onto patch set 4 V -1 07/18/25, 10:23

  10. core-ci voted on patch set 4 V +1 07/18/25, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81922

  11. Benjamin Franzke commented on patch set 4 CR +1 V +1 07/18/25, 10:43

    Reply

    Done
  12. Garvin Hicking commented on patch set 4 07/18/25, 11:11

    Reply

    Done
    12.4 backport is ready with an updated new baseline for v12 code.
  13. Garvin Hicking uploaded patch set 5 CR +1 V +1 07/18/25, 12:16

  14. core-ci voted on patch set 5 V +1 07/18/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81929

  15. Oliver Klee voted on patch set 5 CR +1 V +1 07/18/25, 13:12

  16. Andreas Kienast voted on patch set 5 CR +1 V +1 07/18/25, 13:53

  17. Garvin Hicking voted on patch set 5 CR +2 V +2 07/18/25, 14:36

  18. Garvin Hicking merged patch set 6 07/18/25, 14:36