Review main Merged

90096[TASK] Improve accessibility of new record wizard tab navigation

Andreas Nedbal CR +2 V +2 Easy +31 −3 updated 09/11/25, 15:08

Commit message

The category navigation in the new record wizard is a tab navigation,
so it should follow the principle of tabbing moving to the active panel
instead of the next navigation item.

This change introduces logic to handle arrow key presses to switch
between the navigation items and also adds the required tabindex to
facillitate direct jumping into the content area, fulfilling the
"Tabs Pattern" according to [1].

[1] https://www.w3.org/WAI/ARIA/apg/patterns/tabs/

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1721

  1. Andreas Nedbal uploaded patch set 1 07/18/25, 12:41

  2. Andreas Nedbal updated the commit message in patch set 2 07/18/25, 12:44

  3. core-ci voted on patch set 1 V +1 07/18/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81932

  4. core-ci voted on patch set 2 V +1 07/18/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81933

  5. Andreas Nedbal commented on patch set 2 V -1 07/18/25, 12:56

    Self-blocking until open questions I raised in the Forge issue are cleared up
  6. Andreas Nedbal uploaded patch set 3 V +1 07/18/25, 14:08

  7. Andreas Nedbal commented on patch set 3 07/18/25, 14:14

    Reply

    As mentioned in the Forge issue, I got my answers now and made adjustments, so things are ready from my side.
  8. core-ci voted on patch set 3 V +1 07/18/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81936

  9. Garvin Hicking commented on patch set 3 07/18/25, 14:26

    That's pretty nifty. How would you feel to also support keyboard cursor movement in the right hand side of the wizard for the actual content elements? And how about using cursor left/right to switch between category selection and CE selection?
  10. Andreas Nedbal commented on patch set 3 07/18/25, 14:53

    Reply

    I think that tabbing between the tablist and the tabpanel suffices, I don't think we need arrow key navigation here. As for the keyboard navigation for the items, I'd rather have you open a separate issue to discuss/implement this, as the original bug report I'm resolving also mainly concerns the missing/wrong tab behavior. Just so we don't stretch this out with all accessibility concerns of the New Record Wizard! :)
  11. Garvin Hicking commented on patch set 3 V +1 07/18/25, 15:03

    Reply

    ack, you're right of course. Divide and conquer.
  12. Riccardo De Contardi commented on patch set 3 V +1 08/04/25, 09:26

    Tested on latest main - now it behaves like Bootstrap "Navs & tabs" examples
  13. Christian Rath-Ulrich voted on patch set 3 CR +1 09/03/25, 17:15

  14. Andreas Kienast commented on patch set 3 CR -1 09/11/25, 12:38

    on it
  15. Andreas Kienast uploaded patch set 4 CR +1 V +1 09/11/25, 12:43

  16. Andreas Kienast commented on patch set 4 09/11/25, 12:44

    Reply

    Done
  17. Andreas Kienast voted on patch set 4 CR +1 V +1 09/11/25, 12:47

  18. core-ci voted on patch set 4 V +1 09/11/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84840

  19. Garvin Hicking voted on patch set 4 CR +1 V +1 09/11/25, 13:33

  20. Andreas Nedbal voted on patch set 4 CR +2 V +2 09/11/25, 15:06

  21. Andreas Nedbal merged patch set 5 09/11/25, 15:08