Review main Merged

90097[BUGFIX] Disable indexing of seo_sitemap

Stephan Großberndt CR +2 V +2 Easy +2 −0 updated 07/22/25, 19:27

Commit message

It currently is possible to call /sitemap.xml not only for the root page but for all pages, as it is just a page type. These sitemaps will be indexed and shown as search results by EXT:indexed_search. This change disables the indexing of those sitemaps.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1113

  1. Stephan Großberndt uploaded patch set 1 07/18/25, 13:43

  2. core-ci voted on patch set 1 V +1 07/18/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81935

  3. Garvin Hicking commented on patch set 1 07/18/25, 13:53

    setup.typoscript:7

    should we add a note/comment here that this is affecting indexed_sesrch indexing? Nkt that someone thinks it sets a "noindex" header for search engines...?
  4. Stephan Großberndt uploaded patch set 2 V +1 07/21/25, 07:41

  5. core-ci voted on patch set 2 V +1 07/21/25, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82030

  6. Stephan Großberndt commented on patch set 2 07/21/25, 08:00

    setup.typoscript:7 Reply

    Done
  7. Garvin Hicking voted on patch set 2 CR +1 V +1 07/21/25, 09:49

  8. Guido Schmechel voted on patch set 2 CR +1 V +1 07/21/25, 09:50

  9. Garvin Hicking commented on patch set 2 CR -1 07/21/25, 09:57

    (need to check with core team if a backport to v12 is an option)
  10. Garvin Hicking commented on patch set 2 CR +1 07/21/25, 20:36

    @benni@typo3.org seems fine with a v12 backport, no other objections to my inquiry. :)
  11. Garvin Hicking commented on patch set 2 07/21/25, 20:36

    Reply

    Done
  12. Benni Mack voted on patch set 2 CR +2 V +2 07/22/25, 19:00

  13. Benni Mack merged patch set 3 07/22/25, 19:27