90098[BUGFIX] Make Install Tool AJAX error handling resilient to JS errors
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 912
-
Andreas Nedbal uploaded patch set 1 07/18/25, 15:54
-
Andreas Nedbal uploaded patch set 2 07/18/25, 15:55
-
core-ci voted on patch set 1 V -1 07/18/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81937
-
core-ci voted on patch set 2 V +1 07/18/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81938
-
Garvin Hicking commented on patch set 2 CR +1 V +1 07/18/25, 16:06
I've been caught by this occasionally (in other places). The description in the bug issue to reproduce this helped a lot. Nice! -
Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/18/25, 21:53
-
Garvin Hicking uploaded patch set 3 07/18/25, 22:26
Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Garvin Hicking commented on patch set 3 CR +1 V +1 07/18/25, 22:26
(sorry, don't mind the accidental GIT chain; I made a boo-boo) -
core-ci voted on patch set 3 V +1 07/18/25, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81939
-
Georg Ringer voted on patch set 3 CR +2 V +2 07/29/25, 06:12
-
Georg Ringer merged patch set 4 07/29/25, 06:12
-
Benjamin Franzke commented on patch set 4 07/29/25, 06:47
This patch only fixes the case when the connection from client (browser) to the application server (TYPO3 instance) is broken, but not the case when the connection between TYPO3 instance and TYPO3 language server does not work, that case produces 500 responses. These are actually catched, but the result is shown in a green bar, so that it is hard to detect that a language pack was not just unavailable, but failed to load. > Language packs updated > 0 new language packs downloaded, 0 language packs updated, 0 language packs > skipped, 46 language packs not available We need to differentiate between language packs not being available (404 sent by the language server) and any other 4xx or 5xx or network error that occured when talking to the lanuage server.