Review main Merged

90101[BUGFIX] Ensure request body is writable in ServerRequestInstruction

Oli Bartsch CR +2 V +2 Normal +61 −2 updated 07/22/25, 09:54

Commit message

When deserializing a ServerRequestInstruction
from array data, the body stream was recreated
using the originally stored stream mode (e.g. "rb").
This caused a RuntimeException when attempting to
write to a read-only stream during deserialization.

This patch ensures the stream is always recreated
with mode "w+b" to allow writing. The mode is no
longer serialized via jsonSerialize, as it is
irrelevant and may cause issues on reconstruction.

This issue typically did not occur in Core usage,
as many claims (e.g. from the user management module)
are GET requests with data passed via the query string.
However, custom extensions using POST requests with
a body payload were affected.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 07/21/25, 08:03

  2. core-ci voted on patch set 1 V +1 07/21/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82031

  3. Oli Bartsch uploaded patch set 2 V +1 07/21/25, 08:57

  4. core-ci voted on patch set 2 V +1 07/21/25, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82035

  5. Oliver Hader voted on patch set 2 CR +1 07/21/25, 10:19

  6. Oliver Hader uploaded patch set 3 CR +1 V +1 07/21/25, 11:14

  7. Oliver Hader voted on patch set 3 CR +1 V +1 07/21/25, 11:14

  8. core-ci voted on patch set 3 V +1 07/21/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82058

  9. Benni Mack voted on patch set 3 CR +1 V +1 07/22/25, 08:01

  10. Oli Bartsch voted on patch set 3 CR +2 V +2 07/22/25, 09:54

  11. Oli Bartsch merged patch set 4 07/22/25, 09:54