90104[FEATURE] Render "replace file" dialog in modal
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 32
- Build/Sources/Sass/component/_modal.scss+3 −0
- Build/Sources/Sass/module/_filelist.scss+19 −0
- Build/Sources/TypeScript/backend/element/thumbnail-element.ts+3 −0
- Build/Sources/TypeScript/backend/resource/resource.ts+4 −0
- Build/Sources/TypeScript/backend/utility/format-utility.tsnew+30 −0
- Build/Sources/TypeScript/backend/drag-uploader.ts+6 −17
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+13 −5
- Build/Sources/TypeScript/filelist/file-list-actions.ts+9 −1
- Build/Sources/TypeScript/filelist/file-list-replace-handler.ts6new+141 −0
- Build/Sources/TypeScript/filelist/file-replace.tsdeleted+0 −37
- typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php+73 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php3+16 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_resource.xlf+9 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/thumbnail-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/resource/resource.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/utility/format-utility.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+7 −7
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107435-FileReplaceModalWithEnhancedInformation.rstnew+42 −0
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+0 −3
Show 12 more files
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.phpdeleted+0 −167
- typo3/sysext/filelist/Classes/Controller/FileListController.php+2 −0
- typo3/sysext/filelist/Classes/Dto/ResourceView.php+18 −0
- typo3/sysext/filelist/Classes/EventListener/AfterBackendPageRenderEventListener.php2new+47 −0
- typo3/sysext/filelist/Classes/FileList.php+4 −20
- typo3/sysext/filelist/Configuration/Backend/Routes.php+0 −6
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf+9 −9
- typo3/sysext/filelist/Resources/Private/Templates/File/ReplaceFile.htmldeleted+0 −47
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-replace-handler.jsnew+13 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/file-replace.jsdeleted+0 −13
Review log 3046
Show 1121 earlier messages
-
Andreas Kienast uploaded patch set 1 07/21/25, 10:11
-
core-ci voted on patch set 1 V -1 07/21/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82054
-
Andreas Kienast uploaded patch set 2
V -107/21/25, 12:52 -
core-ci voted on patch set 2 V +1 07/21/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82064
-
Andreas Kienast uploaded patch set 3
V +107/22/25, 08:58 -
core-ci voted on patch set 3 V -1 07/22/25, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82104
-
Andreas Kienast uploaded patch set 4
V -107/29/25, 07:48 -
core-ci voted on patch set 4 V +1 07/29/25, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82468
-
Andreas Kienast uploaded patch set 5
V +107/29/25, 12:08 -
core-ci voted on patch set 5 V +1 07/29/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82489
-
Andreas Kienast uploaded patch set 6
V +107/29/25, 13:34 -
core-ci voted on patch set 6 V +1 07/29/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82496
-
Andreas Kienast uploaded patch set 7
V +108/05/25, 12:23 -
core-ci voted on patch set 7 V -1 08/05/25, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82806
-
Andreas Kienast uploaded patch set 8
V -109/11/25, 11:04 -
core-ci voted on patch set 8 V -1 09/11/25, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84831
-
Andreas Kienast uploaded patch set 9
V -109/11/25, 11:26 -
core-ci voted on patch set 9 V +1 09/11/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84834
-
Georg Ringer commented on patch set 9 V -1 09/11/25, 19:01
exeptions because of failing replacements are not caught and lead to > PHP Warning: Undefined array key 0 in /var/www/html/typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php line 184 after reload, the flash msg states "Mime-type "text/plain" not allowed for file extension "sql" (expected: application/sql, application/x-sql)." how to reproduce: just replace a text/ics file with a sql file -
Andreas Kienast uploaded patch set 10
V +109/12/25, 07:01 -
core-ci voted on patch set 10 V +1 09/12/25, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84883
-
Georg Ringer voted on patch set 10 CR +1 V +1 09/12/25, 08:46
-
Benjamin Franzke uploaded patch set 11
CR +1V +109/12/25, 10:40 -
Benjamin Franzke commented on patch set 11 09/12/25, 10:40
file-list-replace-handler.ts:40I hope it's "OK" that I've added the name in here as context as well. I know that "Rename" doesn't do that yet, but should do so as well (in a separate patch).file-list-replace-handler.ts:111leftover?AjaxRoutes.php:27could also use `inheritAccessFromModule`?AfterBackendPageRenderEventListener.php:26copy/paste leftover -
Benjamin Franzke commented on patch set 11 09/12/25, 10:43
file-list-replace-handler.ts:42our modaly only overflow vertically (`overflow-y: auto`), but not horizontally, that means filenames with roughly ~50 chars will cause horizontal overflows. I like the "small" look in general, but maybe sth. we could look into improving (now or later). Feel free to resolve if you prefer later. -
core-ci voted on patch set 11 V +1 09/12/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84905
-
Andreas Kienast commented on patch set 11 09/12/25, 10:51
file-list-replace-handler.ts:111ReplyGood catch!AjaxRoutes.php:27ReplyI wasn't sure here since we're reading basic meta data only.AfterBackendPageRenderEventListener.php:26ReplyAcknowledged -
Andreas Kienast uploaded patch set 12
V +109/12/25, 11:50 -
core-ci voted on patch set 12 V +1 09/12/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84909
-
Andreas Kienast uploaded patch set 13
V +109/12/25, 11:59 -
core-ci voted on patch set 13 V +1 09/12/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84910
-
Andreas Kienast commented on patch set 13 V -1 09/12/25, 12:15
Investigating a caching bug.file-list-replace-handler.ts:42ReplyDonefile-list-replace-handler.ts:111ReplyDoneAjaxRoutes.php:27ReplyDone -
Andreas Kienast uploaded patch set 14
V +109/12/25, 12:36 -
Andreas Kienast commented on patch set 14 09/12/25, 12:36
Reply
Done -
Andreas Kienast uploaded patch set 15 09/12/25, 12:41
-
core-ci voted on patch set 14 V +1 09/12/25, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84913
-
core-ci voted on patch set 15 V +1 09/12/25, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84914
-
Georg Ringer voted on patch set 15 CR +1 V +1 09/16/25, 18:53
-
Garvin Hicking commented on patch set 15 CR +1 V +1 09/16/25, 19:48
The modal shows the current file name 4 times, but I think for accessibility reasons each one is valid. Thanks for all the work in this patch, I can see the road of pain in this. -
Oli Bartsch commented on patch set 15 CR -1 09/17/25, 08:10
Please wait, will add Feature RST. -
Oli Bartsch uploaded patch set 16
CR +1V +109/18/25, 07:48 -
Oli Bartsch commented on patch set 16 CR +1 V +1 09/18/25, 07:48
Reply
Done -
core-ci voted on patch set 16 V +1 09/18/25, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85115
-
Garvin Hicking voted on patch set 16 CR +1 V +1 09/18/25, 08:01
-
Oli Bartsch voted on patch set 16 CR +2 V +2 09/18/25, 08:02
-
Oli Bartsch merged patch set 17 09/18/25, 08:02