Review main Merged

90104[FEATURE] Render "replace file" dialog in modal

Andreas Kienast CR +2 V +2 Hard +490 −338 updated 09/18/25, 08:02

Commit message

Nowadays there's no need anymore to have this view in a dedicated
controller action, therefore replacing a file now happens in a modal
window, which improves the user experience.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 3046

Show 1121 earlier messages
  1. Andreas Kienast uploaded patch set 1 07/21/25, 10:11

  2. core-ci voted on patch set 1 V -1 07/21/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82054

  3. Andreas Kienast uploaded patch set 2 V -1 07/21/25, 12:52

  4. core-ci voted on patch set 2 V +1 07/21/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82064

  5. Andreas Kienast uploaded patch set 3 V +1 07/22/25, 08:58

  6. core-ci voted on patch set 3 V -1 07/22/25, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82104

  7. Andreas Kienast uploaded patch set 4 V -1 07/29/25, 07:48

  8. core-ci voted on patch set 4 V +1 07/29/25, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82468

  9. Andreas Kienast uploaded patch set 5 V +1 07/29/25, 12:08

  10. core-ci voted on patch set 5 V +1 07/29/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82489

  11. Andreas Kienast uploaded patch set 6 V +1 07/29/25, 13:34

  12. core-ci voted on patch set 6 V +1 07/29/25, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82496

  13. Andreas Kienast uploaded patch set 7 V +1 08/05/25, 12:23

  14. core-ci voted on patch set 7 V -1 08/05/25, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82806

  15. Andreas Kienast uploaded patch set 8 V -1 09/11/25, 11:04

  16. core-ci voted on patch set 8 V -1 09/11/25, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84831

  17. Andreas Kienast uploaded patch set 9 V -1 09/11/25, 11:26

  18. core-ci voted on patch set 9 V +1 09/11/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84834

  19. Georg Ringer commented on patch set 9 V -1 09/11/25, 19:01

    exeptions because of failing replacements are not caught and lead to > PHP Warning: Undefined array key 0 in /var/www/html/typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php line 184 after reload, the flash msg states "Mime-type "text/plain" not allowed for file extension "sql" (expected: application/sql, application/x-sql)." how to reproduce: just replace a text/ics file with a sql file
  20. Andreas Kienast uploaded patch set 10 V +1 09/12/25, 07:01

  21. core-ci voted on patch set 10 V +1 09/12/25, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84883

  1. Georg Ringer voted on patch set 10 CR +1 V +1 09/12/25, 08:46

  2. Benjamin Franzke uploaded patch set 11 CR +1 V +1 09/12/25, 10:40

  3. Benjamin Franzke commented on patch set 11 09/12/25, 10:40

    file-list-replace-handler.ts:40

    I hope it's "OK" that I've added the name in here as context as well. I know that "Rename" doesn't do that yet, but should do so as well (in a separate patch).

    file-list-replace-handler.ts:111

    leftover?

    AjaxRoutes.php:27

    could also use `inheritAccessFromModule`?

    AfterBackendPageRenderEventListener.php:26

    copy/paste leftover
  4. Benjamin Franzke commented on patch set 11 09/12/25, 10:43

    file-list-replace-handler.ts:42

    our modaly only overflow vertically (`overflow-y: auto`), but not horizontally, that means filenames with roughly ~50 chars will cause horizontal overflows. I like the "small" look in general, but maybe sth. we could look into improving (now or later). Feel free to resolve if you prefer later.
  5. core-ci voted on patch set 11 V +1 09/12/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84905

  6. Andreas Kienast commented on patch set 11 09/12/25, 10:51

    file-list-replace-handler.ts:111 Reply

    Good catch!

    AjaxRoutes.php:27 Reply

    I wasn't sure here since we're reading basic meta data only.

    AfterBackendPageRenderEventListener.php:26 Reply

    Acknowledged
  7. Andreas Kienast uploaded patch set 12 V +1 09/12/25, 11:50

  8. core-ci voted on patch set 12 V +1 09/12/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84909

  9. Andreas Kienast uploaded patch set 13 V +1 09/12/25, 11:59

  10. core-ci voted on patch set 13 V +1 09/12/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84910

  11. Andreas Kienast commented on patch set 13 V -1 09/12/25, 12:15

    Investigating a caching bug.

    file-list-replace-handler.ts:42 Reply

    Done

    file-list-replace-handler.ts:111 Reply

    Done

    AjaxRoutes.php:27 Reply

    Done
  12. Andreas Kienast uploaded patch set 14 V +1 09/12/25, 12:36

  13. Andreas Kienast commented on patch set 14 09/12/25, 12:36

    Reply

    Done
  14. Andreas Kienast uploaded patch set 15 09/12/25, 12:41

  15. core-ci voted on patch set 14 V +1 09/12/25, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84913

  16. core-ci voted on patch set 15 V +1 09/12/25, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84914

  17. Georg Ringer voted on patch set 15 CR +1 V +1 09/16/25, 18:53

  18. Garvin Hicking commented on patch set 15 CR +1 V +1 09/16/25, 19:48

    The modal shows the current file name 4 times, but I think for accessibility reasons each one is valid. Thanks for all the work in this patch, I can see the road of pain in this.
  19. Oli Bartsch commented on patch set 15 CR -1 09/17/25, 08:10

    Please wait, will add Feature RST.
  20. Oli Bartsch uploaded patch set 16 CR +1 V +1 09/18/25, 07:48

  21. Oli Bartsch commented on patch set 16 CR +1 V +1 09/18/25, 07:48

    Reply

    Done
  22. core-ci voted on patch set 16 V +1 09/18/25, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85115

  23. Garvin Hicking voted on patch set 16 CR +1 V +1 09/18/25, 08:01

  24. Oli Bartsch voted on patch set 16 CR +2 V +2 09/18/25, 08:02

  25. Oli Bartsch merged patch set 17 09/18/25, 08:02