90109[BUGFIX] Add option parameters for basic setting types
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 26
- Build/Sources/Sass/component/forms/_form-validation.scss+24 −0
- Build/Sources/Sass/component/_alert.scss+1 −0
- Build/Sources/TypeScript/backend/settings/editor/editable-setting.ts+5 −0
- Build/Sources/TypeScript/backend/settings/type/base.ts+5 −2
- Build/Sources/TypeScript/backend/settings/type/int.ts+23 −4
- Build/Sources/TypeScript/backend/settings/type/number.ts+23 −6
- Build/Sources/TypeScript/backend/settings/type/string.ts+21 −6
- Build/Sources/TypeScript/backend/settings/editor.ts+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor/editable-setting.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/base.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/int.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/number.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/string.js+1 −1
- typo3/sysext/core/Classes/Settings/Type/IntType.php+66 −5
- typo3/sysext/core/Classes/Settings/Type/NumberType.php+75 −15
- typo3/sysext/core/Classes/Settings/Type/StringType.php+52 −1
- typo3/sysext/core/Classes/Settings/InvalidSettingDefinitionException.phpnew+23 −0
- typo3/sysext/core/Classes/Settings/SettingDefinition.php+1 −0
- typo3/sysext/core/Classes/Settings/SettingDefinitionValidation.phpnew+102 −0
Show 6 more files
- typo3/sysext/core/Classes/Settings/SettingsTypeOption.phpnew+30 −0
- typo3/sysext/core/Classes/Settings/SettingsTypeOptionAwareInterface.phpnew+31 −0
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+12 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Set1/settings.definitions.yaml+98 −0
- typo3/sysext/core/Tests/Functional/Site/Entity/SiteSettingsTest.php+128 −1
- typo3/sysext/core/Tests/Functional/Site/Set/SetRegistryTest.php+1 −1
Review log 56
-
Benjamin Franzke commented on patch set 1 07/22/25, 06:58
Cherry Picked from branch main. -
Benjamin Franzke marked it work in progress 07/22/25, 06:58
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 07/22/25, 07:02
-
core-ci voted on patch set 1 V +1 07/22/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82091
-
Benjamin Franzke marked it ready for review 07/22/25, 07:13
-
Benjamin Franzke merged patch set 2 07/22/25, 07:13