Review 13.4 Merged

90109[BUGFIX] Add option parameters for basic setting types

Benjamin Franzke CR +2 V +2 Hard +729 −55 updated 07/22/25, 07:13

Commit message

We’re adding missing extensibility to settings types, allowing for
validation, constraints, and other behavior. This includes validation
options for the following types:

- int: min, max, step
- number: min, max, step
- string: min, max

This brings them closer to parity with the constant editor, plus a
small improvement: Stepping is now supported, which wasn’t before.
We’ve limited this to int, number, and string to ensure consistency.

Example usage:

  settings:
    my_sitepackage.int_min_max_step:
      label: int_min_max_step
      category: my_sitepackage
      type: int
      default: 10
      options:
        min: 10
        max: 20
        step: 2

To support options and ensure validation, types now need to implement:
`SettingsTypeOptionAwareInterface`

This interface requires each type to provide its supported options,
which are validated during compile time. This ensures it has no effect
on existing custom types for the settings and as the optional the types
behave the same as before.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 56

  1. Benjamin Franzke commented on patch set 1 07/22/25, 06:58

    Cherry Picked from branch main.
  2. Benjamin Franzke marked it work in progress 07/22/25, 06:58

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 07/22/25, 07:02

  4. core-ci voted on patch set 1 V +1 07/22/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82091

  5. Benjamin Franzke marked it ready for review 07/22/25, 07:13

  6. Benjamin Franzke merged patch set 2 07/22/25, 07:13