Review main Merged

90110[BUGFIX] Load JavaScript importmaps of custom settings types

Benjamin Franzke CR +2 V +2 Easy +7 −3 updated 08/01/25, 09:26

Commit message

Ensure that the JavaScript importmap configuration of custom settings
type providers is loaded inside the settings editor by preloading
all settings types, that will be rendered inside the editor.
This also improves performance of the initial rendering and allows
to drop the inline spinner, which is actually just visible for
a few milliseconds and therefore more distracting than helpful.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Marvin Buchmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Marvin Buchmann +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1117

  1. Benjamin Franzke uploaded patch set 1 07/22/25, 07:55

  2. Benjamin Franzke uploaded patch set 2 07/22/25, 07:58

  3. core-ci voted on patch set 1 V -1 07/22/25, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82094

  4. core-ci voted on patch set 2 V +1 07/22/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82096

  5. Benjamin Franzke rebased onto patch set 3 V +1 07/24/25, 07:02

  6. core-ci voted on patch set 3 V +1 07/24/25, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82218

  7. Benjamin Franzke uploaded patch set 4 V +1 07/28/25, 16:05

  8. core-ci voted on patch set 4 V +1 07/28/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82435

  9. Benjamin Franzke rebased onto patch set 5 V +1 07/30/25, 08:30

  10. core-ci voted on patch set 5 V +1 07/30/25, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82545

  11. Andreas Kienast voted on patch set 5 CR +1 V +1 07/31/25, 13:12

  12. Marvin Buchmann updated the commit message in patch set 6 CR +1 V +1 08/01/25, 09:07

  13. Marvin Buchmann voted on patch set 6 CR +1 V +1 08/01/25, 09:08

  14. Andreas Kienast voted on patch set 6 CR +1 V +1 08/01/25, 09:11

  15. Benjamin Franzke voted on patch set 6 CR +2 V +2 08/01/25, 09:13

  16. core-ci voted on patch set 6 V +1 08/01/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82619

  17. Benjamin Franzke merged patch set 7 08/01/25, 09:26