90112[TASK] Add tests and adjust ambiguity in AstConstantCommentVisitor
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Oliver Hader +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Oliver Hader +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 3
Review log 1621
-
Garvin Hicking uploaded patch set 1 07/22/25, 09:03
-
Garvin Hicking updated the commit message in patch set 2 07/22/25, 09:09
-
core-ci voted on patch set 1 V -1 07/22/25, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82105
-
Garvin Hicking uploaded patch set 3 07/22/25, 09:17
CGL -
core-ci voted on patch set 2 V -1 07/22/25, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82108
-
core-ci voted on patch set 3 V -1 07/22/25, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82110
-
Garvin Hicking uploaded patch set 4
V -107/22/25, 09:33Once more with feeling -
Oliver Hader commented on patch set 3 07/22/25, 09:37
I think this is actually a bugfix, since `int[-5--1]` was evaluated to the range of `[-5;+1]` before - now it's the correct range `[-5;-1]`. The test cases (actually, it's just one test with multiple assertions hidden as test sets) might be split up to have the parser only work on that particular TypoScript snippet - or in case the generic `ext_conf_template.txt` shall stay, put as multiple assertions into one test method. -
Oliver Hader commented on patch set 4 V +1 07/22/25, 09:38
Reply
By just looking at the functionality and behavior, this change looks good. -
core-ci voted on patch set 4 V +1 07/22/25, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82114
-
Garvin Hicking commented on patch set 4 07/22/25, 09:50
Reply
The `[-1--1]` case was actually also properly resolved before this bugfix; `$stop` then gets evaluated to `-1` (not `1`) to make it fall into place (see commit message). So IMO not a true bugfix, but it's quirky. About rewriting the test, I'll likely not have time to do that today. I wanted to avoid too much work into splitting all the chunks up and thought it's better to have this than no test (or just a very small test for this specific case). Doing multiple assertions in one test was something that I tried to avoid due to code review comments in other patches that said to not do that. I'm fine if anyone could/would rework the tests though! -
Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/22/25, 12:18
-
Garvin Hicking uploaded patch set 5
CR +1V +107/22/25, 12:28 -
Garvin Hicking commented on patch set 5 07/22/25, 12:30
Reply
I've reworked the test so that we now have no static member property to 'cache' the expectations, but a single test method that iterates on them. That's all I can offer. Manually juggling these 44 assertions was quite some work; the test method also contains a note why it is what it is. Hope that works for everyone. -
core-ci voted on patch set 5 V +1 07/22/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82125
-
Christian Kuhn voted on patch set 5 CR +1 V +1 07/22/25, 14:14
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 07/23/25, 09:03
-
Oliver Hader voted on patch set 5 CR +1 V +1 07/23/25, 12:09
-
Oliver Hader commented on patch set 5 07/23/25, 12:09
Reply
Thx 😊 -
Garvin Hicking voted on patch set 5 CR +2 V +2 07/23/25, 12:19
-
Garvin Hicking merged patch set 6 07/23/25, 12:20