90118[BUGFIX] Offload decorative thumbnail generation in file list
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Markus Klein +1
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Markus Klein +1
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/component/_tree.scss+7 −3
- Build/Sources/TypeScript/backend/element/thumbnail-element.tsnew+77 −0
- Build/Sources/TypeScript/backend/drag-tooltip.ts+3 −1
- typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php5+32 −0
- typo3/sysext/backend/Configuration/Backend/Routes.php+6 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/thumbnail-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/drag-tooltip.js+1 −1
- typo3/sysext/filelist/Classes/Dto/ResourceView.php+1 −13
- typo3/sysext/filelist/Classes/Type/ThumbnailSize.phpnew+43 −0
- typo3/sysext/filelist/Classes/FileList.php+13 −1
Review log 3038
Show 813 earlier messages
-
Andreas Kienast uploaded patch set 1 07/22/25, 09:41
-
Andreas Kienast uploaded patch set 2 07/22/25, 09:47
-
core-ci voted on patch set 1 V -1 07/22/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82115
-
core-ci voted on patch set 2 V -1 07/22/25, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82116
-
Andreas Kienast uploaded patch set 3
V -107/22/25, 10:54 -
Andreas Kienast commented on patch set 3 07/22/25, 10:58
-
core-ci voted on patch set 3 V +1 07/22/25, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82118
-
Andreas Kienast uploaded patch set 4
V +107/22/25, 11:06 -
Andreas Kienast commented on patch set 4 07/22/25, 11:07
file-list-dragdrop.ts:105ReplyDone -
core-ci voted on patch set 4 V +1 07/22/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82119
-
Andreas Kienast uploaded patch set 5
V +107/22/25, 12:51 -
core-ci voted on patch set 5 V +1 07/22/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82126
-
Andreas Kienast uploaded patch set 6
V +107/22/25, 13:51
-
core-ci voted on patch set 6 V +1 07/22/25, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82130
-
Andreas Kienast uploaded patch set 7
V +107/22/25, 14:03 -
core-ci voted on patch set 7 V +1 07/22/25, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82131
-
Markus Klein voted on patch set 7 CR +1 07/24/25, 12:34
-
Markus Klein commented on patch set 7 07/24/25, 12:37
ResourceController.php:60falseResourceController.php:64do we need any access checks here? -
Markus Klein commented on patch set 7 CR 0 V -1 07/24/25, 12:38
Tiles.html referes to the old thumbnailUrl as well. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/89757/2/typo3/sysext/filelist/Resources/Private/Templates/Filelist/Tiles.html -
Andreas Kienast commented on patch set 7 07/24/25, 12:49
ResourceController.php:60ReplyAcknowledgedResourceController.php:64ReplyI think we can check for read permissions. I don't see any other necessary access check here. -
Andreas Kienast commented on patch set 7 07/24/25, 12:52
Reply
This is fine, as this is the "base URL" used for further processing. -
Andreas Kienast commented on patch set 7 07/24/25, 12:53
Reply
See the changes in FileList.php. -
Andreas Kienast uploaded patch set 8
V +107/24/25, 13:06 -
Andreas Kienast commented on patch set 8 07/24/25, 13:06
ResourceController.php:64ReplyDone -
core-ci voted on patch set 8 V +1 07/24/25, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82242
-
Markus Klein commented on patch set 8 CR +1 07/24/25, 13:48
Reply
Right, I overlooked that you introduce this as public property. Thx.will test the v12 backport on a production instance then -
Markus Klein voted on patch set 8 V +1 07/25/25, 08:48
-
Simon Schaufelberger commented on patch set 8 07/25/25, 09:57
When I start dragging an image, I see 2 requests in the network tab. One request-thumbnail and another with process. Both return a status code of 302 which is a bit strange. Why are 2 requests necessary and why the 302 status code? -
Simon Schaufelberger commented on patch set 8 07/25/25, 10:01
Reply
When I drag the same image again, it takes quite a while for the same thumbnail to appear again. Can't this image (path) also be cached in the browser? -
Andreas Kienast commented on patch set 8 07/25/25, 10:25
Reply
There are two requests if the requested thumbnail image does not exist. The controller pings the processing component, that returns two different URLs: * if the image exists: the path to the file * if the image does not exist: another URL to an internal controller handling the processing, which will render the image and return the blob _somewhen_ This architecture is not great, but not solvable right now. Caching responses would be great, but doesn't work as there is a central middleware that overrides all `Cache-Control` (and related) headers. -
Simon Schaufelberger commented on patch set 8 07/25/25, 13:55
Reply
I'm not sure how it is done with the icons but once they are loaded, the second time the icon is used, it is loaded extremely fast. -
Andreas Kienast commented on patch set 8 07/25/25, 13:59
Reply
The icons are stored in the browser's localStorage. -
Simon Schaufelberger commented on patch set 8 07/25/25, 23:05
Reply
ok but that's not practical here. ACK -
Simon Schaufelberger voted on patch set 8 CR +1 V +1 07/25/25, 23:05
-
Garvin Hicking voted on patch set 8 CR +1 V +1 07/26/25, 05:42
-
Georg Ringer voted on patch set 8 CR +1 V +1 07/27/25, 18:09
-
Andreas Kienast voted on patch set 8 CR +2 V +2 07/28/25, 12:59
-
Andreas Kienast merged patch set 9 07/28/25, 12:59
file-list-dragdrop.ts:105