90119[TASK] Improve Sudo Mode prompt with explanation
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1518
-
Oli Bartsch uploaded patch set 1 07/22/25, 09:53
-
Andreas Kienast commented on patch set 1 07/22/25, 10:00
-
core-ci voted on patch set 1 V +1 07/22/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82117
-
Oli Bartsch commented on patch set 1 07/22/25, 10:05
SudoMode.xlf:37ReplySounds good. However, let's wait for other suggestions. -
Garvin Hicking commented on patch set 1 07/22/25, 17:35
SudoMode.xlf:37Reply$0.02 I like this change and would prefer to have similar terminology, so change both occurences to "enter (...) password to grant acccess". -
Oli Bartsch uploaded patch set 2
V +107/23/25, 06:55 -
Oli Bartsch commented on patch set 2 07/23/25, 06:55
SudoMode.xlf:37ReplyDone -
core-ci voted on patch set 2 V +1 07/23/25, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82160
-
Garvin Hicking voted on patch set 2 CR +1 V +1 07/23/25, 08:02
-
Benni Mack commented on patch set 2 07/24/25, 09:03
SudoMode.xlf:37ReplyI consider "verify your identity" much better because it explains the "why?" behind this, where as grant access answers the "for what" question -
Oli Bartsch commented on patch set 2 07/24/25, 09:11
SudoMode.xlf:37ReplyIt's however true that install tool does not verify an indiviual, therefore I suggest sth. like: "to confirm you are authorized to proceed.", WDYT? -
Oli Bartsch uploaded patch set 3
CR +1V +107/24/25, 14:04 -
core-ci voted on patch set 3 V +1 07/24/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82246
-
Garvin Hicking voted on patch set 3 CR +1 V +1 07/25/25, 08:57
-
Benni Mack voted on patch set 3 CR +1 V +1 07/31/25, 14:30
-
Benni Mack commented on patch set 3 07/31/25, 14:30
SudoMode.xlf:37Replyfine -
Oli Bartsch voted on patch set 3 CR +2 V +2 07/31/25, 16:10
-
Oli Bartsch merged patch set 4 07/31/25, 16:10
SudoMode.xlf:37