Review main Merged

90119[TASK] Improve Sudo Mode prompt with explanation

Oli Bartsch CR +2 V +2 Easy +10 −1 updated 07/31/25, 16:10

Commit message

Previously, the Sudo Mode dialog prompted
users to enter their password without providing
any context. This could lead to confusion, especially
when the prompt appeared in situations not directly
tied to user modification (e.g. accessing protected
backend modules).

This change updates the message to explain that
password entry is a security measure required to
verify the identity before performing actions.

This improves usability and builds trust by
making the system's behavior more transparent.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1518

  1. Oli Bartsch uploaded patch set 1 07/22/25, 09:53

  2. Andreas Kienast commented on patch set 1 07/22/25, 10:00

    SudoMode.xlf:37

    This is technically not correct as the Install Tool password is not bound to any identity (e.g. backend user). What about "… grant access"?
  3. core-ci voted on patch set 1 V +1 07/22/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82117

  4. Oli Bartsch commented on patch set 1 07/22/25, 10:05

    SudoMode.xlf:37 Reply

    Sounds good. However, let's wait for other suggestions.
  5. Garvin Hicking commented on patch set 1 07/22/25, 17:35

    SudoMode.xlf:37 Reply

    $0.02 I like this change and would prefer to have similar terminology, so change both occurences to "enter (...) password to grant acccess".
  6. Oli Bartsch uploaded patch set 2 V +1 07/23/25, 06:55

  7. Oli Bartsch commented on patch set 2 07/23/25, 06:55

    SudoMode.xlf:37 Reply

    Done
  8. core-ci voted on patch set 2 V +1 07/23/25, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82160

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 07/23/25, 08:02

  10. Benni Mack commented on patch set 2 07/24/25, 09:03

    SudoMode.xlf:37 Reply

    I consider "verify your identity" much better because it explains the "why?" behind this, where as grant access answers the "for what" question
  11. Oli Bartsch commented on patch set 2 07/24/25, 09:11

    SudoMode.xlf:37 Reply

    It's however true that install tool does not verify an indiviual, therefore I suggest sth. like: "to confirm you are authorized to proceed.", WDYT?
  12. Oli Bartsch uploaded patch set 3 CR +1 V +1 07/24/25, 14:04

  13. core-ci voted on patch set 3 V +1 07/24/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82246

  14. Garvin Hicking voted on patch set 3 CR +1 V +1 07/25/25, 08:57

  15. Benni Mack voted on patch set 3 CR +1 V +1 07/31/25, 14:30

  16. Benni Mack commented on patch set 3 07/31/25, 14:30

    SudoMode.xlf:37 Reply

    fine
  17. Oli Bartsch voted on patch set 3 CR +2 V +2 07/31/25, 16:10

  18. Oli Bartsch merged patch set 4 07/31/25, 16:10