Review 13.4 Merged

90130[TASK] Update `phpstan/phpstan` to 2.1.19

Garvin Hicking CR +2 V +2 Easy +7 −19 updated 07/23/25, 13:16

Commit message

Executed commands:

    composer require --dev phpstan/phpstan:^2.1.19 -W
    ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Garvin Hicking commented on patch set 1 07/23/25, 12:22

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.lock
  2. core-ci voted on patch set 1 V -1 07/23/25, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82168

  3. Garvin Hicking uploaded patch set 2 V -1 07/23/25, 12:31

    cherry pick
  4. core-ci voted on patch set 2 V +1 07/23/25, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82170

  5. Garvin Hicking marked it ready for review 07/23/25, 12:41

  6. Oliver Klee voted on patch set 2 CR +1 V +1 07/23/25, 12:45

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 07/23/25, 13:16

  8. Garvin Hicking merged patch set 3 07/23/25, 13:16