Review main Merged

90133[TASK] Remove unused PageLayoutResolver injection from PageContentFetchingProcessor

Chris Müller CR +2 V +2 Easy +0 −2 updated 07/24/25, 05:43

Commit message

The PageLayoutResolver is injected via constructor but not used in the
final version's code of the class after refactoring.
Therefore, it can be removed.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Chris Müller uploaded patch set 1 07/23/25, 17:20

  2. core-ci voted on patch set 1 V +1 07/23/25, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82190

  3. Garvin Hicking updated the commit message in patch set 2 V +1 07/23/25, 20:12

  4. Garvin Hicking commented on patch set 2 CR +1 V +1 07/23/25, 20:13

    (Usage was removed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/83638/7..8 when refactoring)
  5. core-ci voted on patch set 2 V +1 07/23/25, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82191

  6. Benni Mack voted on patch set 2 CR +1 V +1 07/24/25, 05:00

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 07/24/25, 05:12

  8. Garvin Hicking merged patch set 3 07/24/25, 05:43