90134[BUGFIX] Utilize DuplicationBehavior ENUM in EXT:form
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Josua Vogel +1
- core-ci +1 CI
Issues 4
Files 1
Review log 1215
-
Garvin Hicking uploaded patch set 1 07/23/25, 20:56
-
core-ci voted on patch set 1 V +1 07/23/25, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82194
-
Josua Vogel commented on patch set 1 CR +1 V +1 07/24/25, 05:56
It works, thank you very much. -
Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/24/25, 09:00
-
Andreas Kienast commented on patch set 1 CR -1 07/25/25, 06:18
UploadedFileReferenceConverter.php:83Please use `DuplicationBehavior::RENAME` only...UploadedFileReferenceConverter.php:210... to allow this: ```suggestion $conflictMode = DuplicationBehavior::tryFrom($configuration->getConfigurationValue(self::class, self::CONFIGURATION_UPLOAD_CONFLICT_MODE)) ?? $this->defaultConflictMode; ``` btw, do we have a validation that checks whether the configured conflict mode is valid?UploadedFileReferenceConverter.php:210Why do we fallback to _another_ default behavior (`cancel`)? -
Garvin Hicking uploaded patch set 2
CR +1V +107/25/25, 07:58 -
Garvin Hicking commented on patch set 2 07/25/25, 08:00
UploadedFileReferenceConverter.php:83ReplyDoneUploadedFileReferenceConverter.php:210ReplyDone. The "validation" would be the TypeError that would probably happen in case of mismatches. We could address this in a follow-up to first fix broken uploads with valid settings for now?UploadedFileReferenceConverter.php:210ReplyDone -
core-ci voted on patch set 2 V -1 07/25/25, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82306
-
Andreas Kienast commented on patch set 2 07/25/25, 08:25
UploadedFileReferenceConverter.php:210Reply`tryFrom()` doesn't throw errors when passing an invalid value, hence the `try`. The existence of validation was just a question, not an order to implement it. -
Garvin Hicking commented on patch set 3
V -107/25/25, 15:32Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 07/25/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82328
-
Josua Vogel voted on patch set 3 CR +1 V +1 07/25/25, 15:52
-
Christian Kuhn voted on patch set 3 CR +1 V +1 07/28/25, 16:02
-
Garvin Hicking voted on patch set 3 CR +2 V +2 07/28/25, 16:06
-
Garvin Hicking merged patch set 4 07/28/25, 16:06