90145[TASK] Allow imports in site set `settings.yaml` files
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+8 −7
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set6/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set6/settings.include.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set6/settings.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Site/Set/YamlSetDefinitionProviderTest.phpnew+52 −0
Review log 710
-
Elias Häußler uploaded patch set 1 07/24/25, 14:31
-
core-ci voted on patch set 1 V -1 07/24/25, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82251
-
Elias Häußler uploaded patch set 2
V -107/24/25, 14:45 -
core-ci voted on patch set 2 V +1 07/24/25, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82254
-
Benjamin Franzke uploaded patch set 3
V +107/24/25, 14:56 -
core-ci voted on patch set 3 V +1 07/24/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82256
-
Garvin Hicking commented on patch set 3 V -1 07/24/25, 16:21
let me check something pls, later this evening -
Garvin Hicking commented on patch set 3 CR +1 V +1 07/24/25, 17:51
Reply
Done -
Benjamin Franzke voted on patch set 3 CR +2 V +2 07/25/25, 06:50
-
Benjamin Franzke merged patch set 4 07/25/25, 06:50