Review 13.4 Merged

90147[BUGFIX] Correctly handle TextTableElement delimiter fallback

Benni Mack CR +2 V +2 Easy +2 −2 updated 07/24/25, 15:34

Commit message

When a table content element has no table_delimiter field,
the first save fails.

A TCA database row's field values are either
- array, when the field is visible in the form
- simple type, when the field is not in the form
  (with its default value)

When saving the element the first time, the table_delimiter default value
is a string "124", causing the `$row['table_delimiter'][0]` to do a
substring operation. This leads to failure.

Upon saving the next time, the default value is an integer and all is
fine.

This patch fixes the problem by checking if the value is really an array
before trying to access the first array element.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 07/24/25, 15:18

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/24/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82258

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/24/25, 15:27

  4. Benni Mack merged patch set 2 07/24/25, 15:34