Review main Merged

90148[TASK] Introduce \TYPO3\CMS\Backend\Routing\Route::fromSymfonyRoute()

Oliver Hader CR +2 V +2 Easy +19 −13 updated 01/26/26, 09:13

Commit message

Internally Symfony\Component\Routing\Route objects are used for
matching the current request to valid routes. In a second step
the result is transformed to \TYPO3\CMS\Backend\Routing\Route
objects. This change centralizes the required transformation
steps in \TYPO3\CMS\Backend\Routing\Route::fromSymfonyRoute().

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Oliver Hader uploaded patch set 1 07/24/25, 21:18

  2. core-ci voted on patch set 1 V -1 07/24/25, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82279

  3. Oliver Hader commented on patch set 2 V -1 07/24/25, 21:37

    Published edit on patch set 1.
  4. Oliver Hader commented on patch set 3 07/24/25, 21:38

    Published edit on patch set 2.
  5. core-ci voted on patch set 3 V +1 07/24/25, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82282

  6. Oliver Hader uploaded patch set 4 V +1 09/02/25, 13:59

  7. core-ci voted on patch set 4 V +1 09/02/25, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84255

  8. Benni Mack voted on patch set 4 CR +1 V +1 09/02/25, 14:57

  9. Simon Schaufelberger voted on patch set 4 CR +1 V +1 01/23/26, 17:14

  10. Josef Glatz updated the commit message in patch set 5 CR +1 V +1 01/23/26, 17:49

  11. core-ci voted on patch set 5 V -1 01/23/26, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94194

  12. Josef Glatz rebased onto patch set 6 V -1 01/23/26, 18:35

  13. core-ci voted on patch set 6 V +1 01/23/26, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94196

  14. Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/23/26, 18:50

  15. Garvin Hicking voted on patch set 6 CR +1 V +1 01/23/26, 21:02

  16. Oliver Hader voted on patch set 6 CR +2 V +2 01/26/26, 09:13

  17. Oliver Hader merged patch set 7 01/26/26, 09:13