Review main Merged

9015[BUGFIX] Update extension must invalidate autoloader cache

Philipp Gampe CR +2 V +2 Easy +2 −0 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Stanislas Rolland +2
    • Susi Moog +1
  • Verified V +2
    • Stanislas Rolland +2
    • Susi Moog +1

Files 1

Review log 23

  1. Markus Klein commented on patch set 1 02/17/12, 19:07

    Looks good to me, but someone else must approve Wouldn't this be a candidate for FYI24?
  2. Georg Ringer commented on patch set 1 02/17/12, 19:07

    Looks good to me, but someone else must approve

    class.tx_em_install.php:265

    flush => Flush
  3. Philipp Gampe commented on patch set 1 02/17/12, 19:07

    I am not a core dev :) If any core dev feels like this is the right place to fix this ... go ahead and merge or make a FYI24 out of it. Although I am not sure if more places are needed, but this is the central install/update extension place in em (according to my findings).

    class.tx_em_install.php:266 Reply

    You are right. I searched for a tag, but I missed it.
  4. Philipp Gampe uploaded patch set 2 02/17/12, 19:07

  5. Susi Moog commented on patch set 3 02/17/12, 19:07

    (1 inline comment)
  6. Philipp Gampe uploaded patch set 3 02/17/12, 19:07

  7. Philipp Gampe commented on patch set 3 02/17/12, 19:07

    (1 inline comment)
  8. Philipp Gampe commented on patch set 3 02/17/12, 19:07

    Seems like git does not like empty descriptions ?! Anyway, I just used a cap for Flush. Please test again. Test suggestion: additional_reports which got a database compare report class with the latest TER version: 1. downgrade the ext 2. clear cache 3. upgrade the extension 4. see the report throw an error without this patch
  9. Philipp Gampe uploaded patch set 4 02/17/12, 19:07

  10. Stanislas Rolland commented on patch set 5 V 0 02/17/12, 19:07

    by team member; Looks good to me, approved
  11. Susi Moog commented on patch set 5 02/17/12, 19:07

    Verified; Looks good to me, but someone else must approve
  12. Philipp Gampe uploaded patch set 5 02/17/12, 19:07

  13. Mr. Jenkins commented on patch set 1 02/17/12, 19:07

    No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3251/ : SUCCESS
  14. Mr. Jenkins commented on patch set 1 02/17/12, 19:07

  15. Mr. Jenkins commented on patch set 1 02/17/12, 19:07

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3247/ : FAILURE
  16. Mr. Jenkins commented on patch set 1 02/17/12, 19:07

  17. Mr. Jenkins commented on patch set 1 02/17/12, 19:07

  18. Mr. Jenkins commented on patch set 1 02/17/12, 19:07

  19. Mr. Jenkins commented on patch set 2 02/17/12, 19:07

  20. Mr. Jenkins commented on patch set 3 02/17/12, 19:07

  21. Mr. Jenkins commented on patch set 4 02/17/12, 19:07

  22. Mr. Jenkins commented on patch set 5 02/17/12, 19:07

  23. Stanislas Rolland merged patch set 5 02/17/12, 19:07