9015[BUGFIX] Update extension must invalidate autoloader cache
Commit message
Review
-
Code review CR +2
- Stanislas Rolland +2
- Susi Moog +1
-
Verified V +2
- Stanislas Rolland +2
- Susi Moog +1
Files 1
Review log 23
-
Markus Klein commented on patch set 1 02/17/12, 19:07
Looks good to me, but someone else must approve Wouldn't this be a candidate for FYI24? -
Georg Ringer commented on patch set 1 02/17/12, 19:07
Looks good to me, but someone else must approveclass.tx_em_install.php:265flush => Flush -
Philipp Gampe commented on patch set 1 02/17/12, 19:07
I am not a core dev :) If any core dev feels like this is the right place to fix this ... go ahead and merge or make a FYI24 out of it. Although I am not sure if more places are needed, but this is the central install/update extension place in em (according to my findings).class.tx_em_install.php:266ReplyYou are right. I searched for a tag, but I missed it. -
Philipp Gampe uploaded patch set 2 02/17/12, 19:07
-
Susi Moog commented on patch set 3 02/17/12, 19:07
(1 inline comment) -
Philipp Gampe uploaded patch set 3 02/17/12, 19:07
-
Philipp Gampe commented on patch set 3 02/17/12, 19:07
(1 inline comment) -
Philipp Gampe commented on patch set 3 02/17/12, 19:07
Seems like git does not like empty descriptions ?! Anyway, I just used a cap for Flush. Please test again. Test suggestion: additional_reports which got a database compare report class with the latest TER version: 1. downgrade the ext 2. clear cache 3. upgrade the extension 4. see the report throw an error without this patch -
Philipp Gampe uploaded patch set 4 02/17/12, 19:07
-
Stanislas Rolland commented on patch set 5 V 0 02/17/12, 19:07
by team member; Looks good to me, approved -
Susi Moog commented on patch set 5 02/17/12, 19:07
Verified; Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 5 02/17/12, 19:07
-
Mr. Jenkins commented on patch set 1 02/17/12, 19:07
No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3251/ : SUCCESS -
Mr. Jenkins commented on patch set 1 02/17/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3246/ : SUCCESS -
Mr. Jenkins commented on patch set 1 02/17/12, 19:07
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3247/ : FAILURE -
Mr. Jenkins commented on patch set 1 02/17/12, 19:07
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3248/ : FAILURE -
Mr. Jenkins commented on patch set 1 02/17/12, 19:07
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3249/ : FAILURE -
Mr. Jenkins commented on patch set 1 02/17/12, 19:07
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3250/ : FAILURE -
Mr. Jenkins commented on patch set 2 02/17/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3265/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/17/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3266/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/17/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3298/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/17/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3299/ : SUCCESS -
Stanislas Rolland merged patch set 5 02/17/12, 19:07