Review 13.4 Merged

90153[BUGFIX] Skip consistency checks in ResourceStorage::addUploadedFile

Oliver Hader CR +2 V +2 Easy +1 −1 updated 09/12/25, 13:10

Commit message

`ResourceStorage::addUploadedFilе` currently invokes the resource
consistency checks - which is invoked again in subsequent calls
of `addUploadedFile` to either `replaceFile` or `addFile`.
As a result, skipping consistency checks did not work in this
case, since skip instructions are revoked immediately.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2

Issues 1

Files 1

Review log 710

  1. Oliver Hader uploaded patch set 1 07/25/25, 08:50

  2. core-ci voted on patch set 1 V +1 07/25/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82309

  3. Oliver Hader rebased onto patch set 2 V +1 08/28/25, 19:06

  4. core-ci voted on patch set 2 V +1 08/28/25, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83944

  5. Garvin Hicking commented on patch set 3 V +1 09/12/25, 13:01

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/ResourceStorage.php
  6. Garvin Hicking commented on patch set 4 09/12/25, 13:02

    Published edit on patch set 3.
  7. Garvin Hicking marked it ready for review 09/12/25, 13:03

  8. Garvin Hicking voted on patch set 4 CR +2 V +2 09/12/25, 13:04

  9. Garvin Hicking merged patch set 5 09/12/25, 13:05

  10. core-ci voted on patch set 4 V +1 09/12/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84918