90158[BUGFIX] Make icon grid in EXT:styleguide context aware
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Andreas Wolf +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Riccardo De Contardi +1
- Andreas Kienast +1
- Andreas Wolf +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1317
-
Andreas Kienast uploaded patch set 1 07/25/25, 12:28
-
core-ci voted on patch set 1 V +1 07/25/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82318
-
Georg Ringer updated the commit message in patch set 2
V +107/27/25, 14:22 -
core-ci voted on patch set 2 V +1 07/27/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82380
-
Benjamin Franzke uploaded patch set 3
V +107/28/25, 12:58 -
Benjamin Franzke uploaded patch set 4
CR +1V +107/28/25, 13:03 -
core-ci voted on patch set 3 V +1 07/28/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82424
-
Andreas Kienast commented on patch set 4 07/28/25, 13:06
I'm not sure whether I like the layout shift when I hover over the tiles -
Andreas Kienast commented on patch set 4 07/28/25, 13:07
Reply
_unresolved..._ -
core-ci voted on patch set 4 V +1 07/28/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82425
-
Benjamin Franzke commented on patch set 4 07/28/25, 13:37
Reply
I think this is less ugly than the inconsistent spacings that where added previously 😋 But we can make it a copy-button instead and always apply text ellipsis in order to never layout shift (and improve the min width, to let this case happen more seldomly), that way the transition makes more sense. Currently it just feels like it should trigger a functionality, but there is none. -
Andreas Kienast commented on patch set 4 V +1 08/01/25, 09:47
Reply
Done -
Andreas Kienast voted on patch set 4 CR +1 08/01/25, 09:48
-
Riccardo De Contardi commented on patch set 4 V +1 08/04/25, 09:22
tested on latest main -
Andreas Wolf voted on patch set 4 CR +1 V +1 08/07/25, 21:39
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 08/08/25, 07:22
-
Benjamin Franzke merged patch set 5 08/08/25, 07:22