Review main Merged

90158[BUGFIX] Make icon grid in EXT:styleguide context aware

Andreas Kienast CR +2 V +2 Normal +32 −19 updated 08/08/25, 07:22

Commit message

The icon grid rendered in EXT:styleguide now does not use any hard-coded
colors anymore and has been made context-aware.

Also, the icons are now rendered in a plain CSS grid and background
color changes are transitioned.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Andreas Wolf +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Riccardo De Contardi +1
    • Andreas Kienast +1
    • Andreas Wolf +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Andreas Kienast uploaded patch set 1 07/25/25, 12:28

  2. core-ci voted on patch set 1 V +1 07/25/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82318

  3. Georg Ringer updated the commit message in patch set 2 V +1 07/27/25, 14:22

  4. core-ci voted on patch set 2 V +1 07/27/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82380

  5. Benjamin Franzke uploaded patch set 3 V +1 07/28/25, 12:58

  6. Benjamin Franzke uploaded patch set 4 CR +1 V +1 07/28/25, 13:03

  7. core-ci voted on patch set 3 V +1 07/28/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82424

  8. Andreas Kienast commented on patch set 4 07/28/25, 13:06

    I'm not sure whether I like the layout shift when I hover over the tiles
  9. Andreas Kienast commented on patch set 4 07/28/25, 13:07

    Reply

    _unresolved..._
  10. core-ci voted on patch set 4 V +1 07/28/25, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82425

  11. Benjamin Franzke commented on patch set 4 07/28/25, 13:37

    Reply

    I think this is less ugly than the inconsistent spacings that where added previously 😋 But we can make it a copy-button instead and always apply text ellipsis in order to never layout shift (and improve the min width, to let this case happen more seldomly), that way the transition makes more sense. Currently it just feels like it should trigger a functionality, but there is none.
  12. Andreas Kienast commented on patch set 4 V +1 08/01/25, 09:47

    Reply

    Done
  13. Andreas Kienast voted on patch set 4 CR +1 08/01/25, 09:48

  14. Riccardo De Contardi commented on patch set 4 V +1 08/04/25, 09:22

    tested on latest main
  15. Andreas Wolf voted on patch set 4 CR +1 V +1 08/07/25, 21:39

  16. Benjamin Franzke voted on patch set 4 CR +2 V +2 08/08/25, 07:22

  17. Benjamin Franzke merged patch set 5 08/08/25, 07:22