Review main Merged

90160[DOCS] Improve FAQ about duplicate form submission

Josua Vogel CR +2 V +2 Easy +19 −7 updated 08/11/25, 13:27

Commit message

The recommended solution using JavaScript has been updated
so that the submit button is not disabled.
This ensures that the step number is transmitted.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Osswald +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1923

  1. Josua Vogel uploaded patch set 1 07/25/25, 14:31

  2. core-ci voted on patch set 1 V +1 07/25/25, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82323

  3. Simon Schaufelberger commented on patch set 1 07/25/25, 15:03

    Index.rst:116

    2 spaces after =
  4. Josua Vogel uploaded patch set 2 V +1 07/25/25, 15:06

  5. Josua Vogel commented on patch set 2 07/25/25, 15:06

    Index.rst:116 Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/25/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82327

  7. Sven Liebert voted on patch set 2 CR +1 V +1 07/25/25, 17:28

  8. Oliver Klee voted on patch set 2 CR +1 07/26/25, 11:25

  9. Andreas Kienast commented on patch set 2 07/28/25, 12:00

    Pardon my ignorance, I have one question here. The example code snippet listens on the `submit` event and disables the submit button once the event is dispatched (probably to avoid submitting the same form multiple times). Isn't the event dispatched once the form has been submitted already and thus all data was sent? Disabling a field _after_ the submission cannot have an effect on the submitted payload retroactively.
  10. Josua Vogel commented on patch set 2 07/28/25, 14:33

    Reply

    No, the submit has not yet been executed. The event can be used to prevent a submit or to manipulate/validate the form data before the request is sent.
  11. Andreas Kienast commented on patch set 2 08/01/25, 09:31

    Reply

    Of course, you're absolutely right. My bad.
  12. Andreas Kienast commented on patch set 2 08/01/25, 10:00

    Index.rst:118

    I opt to include a CSS sample that applies styling to the class `.submitted`. With the old snippet, the button is technically _and_ visually disabled, the latter one is missing with the new approach.
  13. Josua Vogel uploaded patch set 3 CR +1 V +1 08/01/25, 10:18

  14. Josua Vogel commented on patch set 3 08/01/25, 10:19

    Index.rst:118 Reply

    Done
  15. Sven Liebert voted on patch set 3 CR +1 V +1 08/01/25, 10:22

  16. Oliver Klee voted on patch set 3 CR +1 08/01/25, 10:23

  17. core-ci voted on patch set 3 V +1 08/01/25, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82625

  18. Josua Vogel commented on patch set 4 CR +1 V +1 08/01/25, 12:52

    Published edit on patch set 3.
  19. core-ci voted on patch set 4 V +1 08/01/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82635

  20. Sven Liebert voted on patch set 4 CR +1 V +1 08/04/25, 07:31

  21. Christian Osswald voted on patch set 4 CR +1 08/07/25, 19:16

  22. Andreas Kienast voted on patch set 4 CR +2 V +2 08/11/25, 12:52

  23. Andreas Kienast merged patch set 5 08/11/25, 13:27