90198[TASK] Fix duplicate styleguide ext_conf_template category IDs
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Garvin Hicking +1
- Andreas Kienast +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Benjamin Franzke uploaded patch set 1 07/30/25, 08:30
-
Garvin Hicking voted on patch set 1 CR +1 V +1 07/30/25, 08:35
-
core-ci voted on patch set 1 V +1 07/30/25, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82549
-
Simon Schaufelberger commented on patch set 1 CR +1 V +1 07/30/25, 08:52
I would call it a BUGFIX instead of a TASK but ok... -
Oliver Klee voted on patch set 1 CR +1 07/30/25, 09:19
-
Benjamin Franzke commented on patch set 1 07/30/25, 09:26
Reply
Thanks for your feedback. My reasoning is: It's not a BUG in our application that an enduser faces. This aspect of `EXT:styleguide` is targeted for testing variants and therefore does not qualify as a BUGFIX, but as a cleanup. -
Simon Schaufelberger commented on patch set 1 07/30/25, 09:39
Reply
ok then ready to merge! -
Andreas Kienast voted on patch set 1 CR +1 V +1 08/01/25, 08:46
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 08/01/25, 08:46
-
Benjamin Franzke merged patch set 2 08/01/25, 08:57