Review main Merged

90200[BUGFIX] RedisSessionBackend must allow to select db 0

Markus Klein CR +2 V +2 Easy +1 −1 updated 08/04/25, 07:16

Commit message

A wrong condition, existing since ever, denied connecting
to a Redis database number 0 for session storage.

This patch fixes the condition.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Rémi Payette +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1112

  1. Markus Klein uploaded patch set 1 07/30/25, 12:00

  2. core-ci voted on patch set 1 V +1 07/30/25, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82553

  3. Benni Mack commented on patch set 1 CR +1 07/30/25, 12:53

    The issue was introduced 10 years ago https://review.typo3.org/c/Packages/TYPO3.CMS/+/51549, and apparently wasn't a problem until now. How do you justify this as a critical bugfix now?
  4. Rémi Payette voted on patch set 1 CR +1 07/30/25, 14:38

  5. Rémi Payette commented on patch set 1 07/30/25, 15:24

    This is exactly what I also did locally to fix the issue.
  6. Markus Klein commented on patch set 1 07/30/25, 21:23

    Reply

    Not, not critical. But as you know, my approach is rather: Fix it, if it's easily doable. In this case my thought was: Who uses Redis for sessions? Rather advanced setups. Those are the ones being later in the upgrade process usually, hence are happy for any improvement once they reach v12.
  7. Benni Mack commented on patch set 1 07/31/25, 09:01

    Reply

    Done
  8. Oliver Klee voted on patch set 1 CR +1 07/31/25, 09:26

  9. Andreas Kienast voted on patch set 1 CR +1 08/01/25, 12:14

  10. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/02/25, 08:21

  11. Benni Mack voted on patch set 1 CR +2 V +2 08/04/25, 07:16

  12. Benni Mack merged patch set 2 08/04/25, 07:16