90201[FEATURE] Add PSR-14 events to beuser extension
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php4+18 −6
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserGroupRepository.php2+8 −1
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php2+8 −0
- typo3/sysext/beuser/Classes/Event/AfterBackendGroupFilterListIsAssembledEvent.phpnew+31 −0
- typo3/sysext/beuser/Classes/Event/AfterBackendGroupListConstraintsAssembledFromDemandEvent.phpnew+33 −0
- typo3/sysext/beuser/Classes/Event/AfterBackendUserListConstraintsAssembledFromDemandEvent.phpnew+33 −0
- typo3/sysext/beuser/Classes/Event/AfterFilemountsListIsAssembledEvent.phpnew+31 −0
- typo3/sysext/beuser/Tests/Functional/Controller/BackendUserControllerTest.phpnew+140 −0
- typo3/sysext/beuser/Tests/Functional/Domain/Model/BackendUserGroupRepositoryTest.php2new+64 −0
- typo3/sysext/beuser/Tests/Functional/Domain/Model/BackendUserRepositoryTest.php2new+64 −0
- typo3/sysext/beuser/Tests/Functional/Fixtures/be_groups.csvnew+4 −0
- typo3/sysext/beuser/Tests/Functional/Fixtures/be_users.csvnew+4 −0
- typo3/sysext/beuser/Tests/Functional/Fixtures/sys_filemounts.csvnew+7 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107180-IntroducePSR14EventsForBeuserModule.rst11new+178 −0
Review log 3649
Show 1724 earlier messages
-
Francois Suter uploaded patch set 1 07/30/25, 15:30
-
core-ci voted on patch set 1 V +1 07/30/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82555
-
Garvin Hicking commented on patch set 1 07/30/25, 15:49
This looks promising and I can follow your use case. Thanks for sharing and offering this patch! :) If we can add tests and the feature rst's I think we should go forward with this. Before you do this legwork though I hope we can get more feedback. -
Simon Schaufelberger commented on patch set 1 07/30/25, 23:00
BackendUserGroupRepository.php:43can be readonlyBackendUserRepository.php:38can be readonlyModifyBackendGroupListConstraintsEvent.php:28use newline please for every property and use readonly. Final classes can't be extended, therefore everything can be privateModifyBackendGroupListConstraintsEvent.php:49empty line can be removedModifyBackendUserListConstraintsEvent.php:28same hereProcessBackendGroupFilterListEvent.php:25same here -
Stefan Bürk commented on patch set 1 08/01/25, 10:59
I'd say before making this a quick feature, this should be coordinated / verified with other things going on in this area - and decided if other changes needs to be done first before doing this change because it would change things/events again. * https://review.typo3.org/c/Packages/TYPO3.CMS/+/82189 * https://review.typo3.org/c/Packages/TYPO3.CMS/+/85577 TBH not reviewed this chainge in detail. -
Francois Suter commented on patch set 1 08/01/25, 17:36
Reply
Thanks for pointing this out. As far as I can see, there's no contradiction, neither any relation between the 2 features. Note that I haven't meant this to be a "quick feature". There's a clear purpose, described in detail in the Forge ticket.Reply
Indeed, that's my intention: gathering feedback, making the patch more complete, and then making it squeaky clean. -
Francois Suter commented on patch set 1 08/01/25, 17:45
BackendUserGroupRepository.php:43ReplyActually useless, I had missed that the base class already has an EventDispatcher member variable.BackendUserRepository.php:38ReplyActually useless, I had missed that the base class already has an EventDispatcher member variable.ModifyBackendGroupListConstraintsEvent.php:28ReplyAcknowledgedModifyBackendGroupListConstraintsEvent.php:49ReplyAcknowledgedModifyBackendUserListConstraintsEvent.php:28ReplyAcknowledgedProcessBackendGroupFilterListEvent.php:25ReplyAcknowledged -
Francois Suter uploaded patch set 2
V +108/01/25, 17:46 -
core-ci voted on patch set 2 V +1 08/01/25, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82642
-
Francois Suter uploaded patch set 3
V +110/06/25, 20:19 -
core-ci voted on patch set 3 V -1 10/06/25, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86098
-
Francois Suter uploaded patch set 4
V -110/07/25, 05:57 -
core-ci voted on patch set 4 V +1 10/07/25, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86124
-
Francois Suter uploaded patch set 5
V +110/27/25, 17:33 -
core-ci voted on patch set 5 V -1 10/27/25, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87695
-
Oli Bartsch uploaded patch set 6
V -110/27/25, 18:52 -
core-ci voted on patch set 6 V -1 10/27/25, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87716
-
Francois Suter uploaded patch set 7
V -110/28/25, 10:48 -
core-ci voted on patch set 7 V -1 10/28/25, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87794
-
Francois Suter uploaded patch set 8
V -110/28/25, 10:58 -
Oliver Hader commented on patch set 7 10/28/25, 11:01
Looks good in general.BackendUserGroupRepositoryTest.php:30`final class ...` missing hereBackendUserRepositoryTest.php:30`final class ...` missing here -
Guido Schmechel commented on patch set 8 10/28/25, 11:02
Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1In general, I think it would be great if we could add examples to the RST. We often use this as a guide in other PSR 14 events.Feature-107180-IntroducePSR14EventsForBeuserModule.rst:66mount -
Francois Suter commented on patch set 8 10/28/25, 11:03
Thanks for the review. The changes were made in patchset 8 following CI remarks.BackendUserGroupRepositoryTest.php:30ReplyDoneBackendUserRepositoryTest.php:30ReplyDone -
Francois Suter commented on patch set 8 10/28/25, 11:10
Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1ReplyOK. I felt that it was a bit overwhelming since there are 4 events, but I can do it.Feature-107180-IntroducePSR14EventsForBeuserModule.rst:66ReplyWill fix, thanks.
-
core-ci voted on patch set 8 V +1 10/28/25, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87799
-
Guido Schmechel commented on patch set 8 10/28/25, 11:39
Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1ReplyThank you! That can then be perfectly incorporated into the documentation. Example structure: https://docs.typo3.org/c/typo3/cms-core/main/en-us//Changelog/14.0/Feature-99409-NewPSR-14BeforeLiveSearchFormIsBuiltEvent.html The examples also help a little bit to classify what one could do. -
Francois Suter commented on patch set 8 10/28/25, 11:49
Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1ReplyAcknowledgedFeature-107180-IntroducePSR14EventsForBeuserModule.rst:66ReplyAcknowledged -
Francois Suter uploaded patch set 9
V +110/28/25, 12:11 -
Francois Suter commented on patch set 9 10/28/25, 12:13
The latest patchset adds the requested examples in the ChangeLog file. All events have been renamed so that they reflect the context in which they are called rather than my intention in introducing the events (thanks Benni), -
core-ci voted on patch set 9 V +1 10/28/25, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87815
-
Benni Mack commented on patch set 9 10/28/25, 12:55
BackendUserController.php:170I think we should add the request object to the Event.BackendUserController.php:614I think we should add the request object to the Event. -
Christian Kuhn commented on patch set 9 10/28/25, 13:08
Feature-107180-IntroducePSR14EventsForBeuserModule.rst:163do you think it would be a good idea to have a small disclaimer here stating that manipulating this data is in general a security sensitive topic and consumers should be crafted carefully in this regard? -
Francois Suter uploaded patch set 10
V +110/28/25, 15:05 -
Francois Suter commented on patch set 9 10/28/25, 15:05
BackendUserController.php:170ReplyDoneBackendUserController.php:614ReplyDoneFeature-107180-IntroducePSR14EventsForBeuserModule.rst:163ReplyNote added in patchset 10 -
core-ci voted on patch set 10 V +1 10/28/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87845
-
Benni Mack uploaded patch set 11
V +110/29/25, 09:59 -
core-ci voted on patch set 11 V +1 10/29/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87928
-
Benni Mack voted on patch set 11 CR +1 V +1 10/29/25, 15:04
-
Oli Bartsch commented on patch set 11 CR -1 10/29/25, 20:17
on it -
Oli Bartsch commented on patch set 11 10/29/25, 20:43
Feature-107180-IntroducePSR14EventsForBeuserModule.rst:157This does not work. $event->filemounts is a QueryResultInterface -
Oli Bartsch uploaded patch set 12
CR +1V +110/29/25, 20:58 -
Oli Bartsch commented on patch set 12 CR +1 V +1 10/29/25, 20:58
Reply
DoneFeature-107180-IntroducePSR14EventsForBeuserModule.rst:157ReplyDone -
core-ci voted on patch set 12 V -1 10/29/25, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88050
-
Oli Bartsch uploaded patch set 13
CR +1V +110/29/25, 21:22 -
Oli Bartsch voted on patch set 13 CR +1 V +1 10/29/25, 21:23
-
core-ci voted on patch set 13 V +1 10/29/25, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88054
-
Benni Mack voted on patch set 13 CR +1 V +1 10/29/25, 21:47
-
Oli Bartsch voted on patch set 13 CR +2 V +2 10/29/25, 21:51
-
Oli Bartsch merged patch set 14 10/29/25, 21:51