Review main Merged

90201[FEATURE] Add PSR-14 events to beuser extension

Francois Suter CR +2 V +2 Hard +623 −7 updated 10/29/25, 21:51

Commit message

Adds several events to the beuser extension in order to make it possible
to introduce a more refined user management for sites with large number
of users and groups, and also users who manage other users (reference
is the "my_user_management" extension).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 3649

Show 1724 earlier messages
  1. Francois Suter uploaded patch set 1 07/30/25, 15:30

  2. core-ci voted on patch set 1 V +1 07/30/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82555

  3. Garvin Hicking commented on patch set 1 07/30/25, 15:49

    This looks promising and I can follow your use case. Thanks for sharing and offering this patch! :) If we can add tests and the feature rst's I think we should go forward with this. Before you do this legwork though I hope we can get more feedback.
  4. Simon Schaufelberger commented on patch set 1 07/30/25, 23:00

    BackendUserGroupRepository.php:43

    can be readonly

    BackendUserRepository.php:38

    can be readonly

    ModifyBackendGroupListConstraintsEvent.php:28

    use newline please for every property and use readonly. Final classes can't be extended, therefore everything can be private

    ModifyBackendGroupListConstraintsEvent.php:49

    empty line can be removed

    ModifyBackendUserListConstraintsEvent.php:28

    same here

    ProcessBackendGroupFilterListEvent.php:25

    same here
  5. Stefan Bürk commented on patch set 1 08/01/25, 10:59

    I'd say before making this a quick feature, this should be coordinated / verified with other things going on in this area - and decided if other changes needs to be done first before doing this change because it would change things/events again. * https://review.typo3.org/c/Packages/TYPO3.CMS/+/82189 * https://review.typo3.org/c/Packages/TYPO3.CMS/+/85577 TBH not reviewed this chainge in detail.
  6. Francois Suter commented on patch set 1 08/01/25, 17:36

    Reply

    Thanks for pointing this out. As far as I can see, there's no contradiction, neither any relation between the 2 features. Note that I haven't meant this to be a "quick feature". There's a clear purpose, described in detail in the Forge ticket.

    Reply

    Indeed, that's my intention: gathering feedback, making the patch more complete, and then making it squeaky clean.
  7. Francois Suter commented on patch set 1 08/01/25, 17:45

    BackendUserGroupRepository.php:43 Reply

    Actually useless, I had missed that the base class already has an EventDispatcher member variable.

    BackendUserRepository.php:38 Reply

    Actually useless, I had missed that the base class already has an EventDispatcher member variable.

    ModifyBackendGroupListConstraintsEvent.php:28 Reply

    Acknowledged

    ModifyBackendGroupListConstraintsEvent.php:49 Reply

    Acknowledged

    ModifyBackendUserListConstraintsEvent.php:28 Reply

    Acknowledged

    ProcessBackendGroupFilterListEvent.php:25 Reply

    Acknowledged
  8. Francois Suter uploaded patch set 2 V +1 08/01/25, 17:46

  9. core-ci voted on patch set 2 V +1 08/01/25, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82642

  10. Francois Suter uploaded patch set 3 V +1 10/06/25, 20:19

  11. core-ci voted on patch set 3 V -1 10/06/25, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86098

  12. Francois Suter uploaded patch set 4 V -1 10/07/25, 05:57

  13. core-ci voted on patch set 4 V +1 10/07/25, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86124

  14. Francois Suter uploaded patch set 5 V +1 10/27/25, 17:33

  15. core-ci voted on patch set 5 V -1 10/27/25, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87695

  16. Oli Bartsch uploaded patch set 6 V -1 10/27/25, 18:52

  17. core-ci voted on patch set 6 V -1 10/27/25, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87716

  18. Francois Suter uploaded patch set 7 V -1 10/28/25, 10:48

  19. core-ci voted on patch set 7 V -1 10/28/25, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87794

  20. Francois Suter uploaded patch set 8 V -1 10/28/25, 10:58

  21. Oliver Hader commented on patch set 7 10/28/25, 11:01

    Looks good in general.

    BackendUserGroupRepositoryTest.php:30

    `final class ...` missing here

    BackendUserRepositoryTest.php:30

    `final class ...` missing here
  22. Guido Schmechel commented on patch set 8 10/28/25, 11:02

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1

    In general, I think it would be great if we could add examples to the RST. We often use this as a guide in other PSR 14 events.

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:66

    mount
  23. Francois Suter commented on patch set 8 10/28/25, 11:03

    Thanks for the review. The changes were made in patchset 8 following CI remarks.

    BackendUserGroupRepositoryTest.php:30 Reply

    Done

    BackendUserRepositoryTest.php:30 Reply

    Done
  24. Francois Suter commented on patch set 8 10/28/25, 11:10

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1 Reply

    OK. I felt that it was a bit overwhelming since there are 4 events, but I can do it.

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:66 Reply

    Will fix, thanks.
  1. core-ci voted on patch set 8 V +1 10/28/25, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87799

  2. Guido Schmechel commented on patch set 8 10/28/25, 11:39

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1 Reply

    Thank you! That can then be perfectly incorporated into the documentation. Example structure: https://docs.typo3.org/c/typo3/cms-core/main/en-us//Changelog/14.0/Feature-99409-NewPSR-14BeforeLiveSearchFormIsBuiltEvent.html The examples also help a little bit to classify what one could do.
  3. Francois Suter commented on patch set 8 10/28/25, 11:49

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:1 Reply

    Acknowledged

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:66 Reply

    Acknowledged
  4. Francois Suter uploaded patch set 9 V +1 10/28/25, 12:11

  5. Francois Suter commented on patch set 9 10/28/25, 12:13

    The latest patchset adds the requested examples in the ChangeLog file. All events have been renamed so that they reflect the context in which they are called rather than my intention in introducing the events (thanks Benni),
  6. core-ci voted on patch set 9 V +1 10/28/25, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87815

  7. Benni Mack commented on patch set 9 10/28/25, 12:55

    BackendUserController.php:170

    I think we should add the request object to the Event.

    BackendUserController.php:614

    I think we should add the request object to the Event.
  8. Christian Kuhn commented on patch set 9 10/28/25, 13:08

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:163

    do you think it would be a good idea to have a small disclaimer here stating that manipulating this data is in general a security sensitive topic and consumers should be crafted carefully in this regard?
  9. Francois Suter uploaded patch set 10 V +1 10/28/25, 15:05

  10. Francois Suter commented on patch set 9 10/28/25, 15:05

    BackendUserController.php:170 Reply

    Done

    BackendUserController.php:614 Reply

    Done

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:163 Reply

    Note added in patchset 10
  11. core-ci voted on patch set 10 V +1 10/28/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87845

  12. Benni Mack uploaded patch set 11 V +1 10/29/25, 09:59

  13. core-ci voted on patch set 11 V +1 10/29/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87928

  14. Benni Mack voted on patch set 11 CR +1 V +1 10/29/25, 15:04

  15. Oli Bartsch commented on patch set 11 CR -1 10/29/25, 20:17

    on it
  16. Oli Bartsch commented on patch set 11 10/29/25, 20:43

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:157

    This does not work. $event->filemounts is a QueryResultInterface
  17. Oli Bartsch uploaded patch set 12 CR +1 V +1 10/29/25, 20:58

  18. Oli Bartsch commented on patch set 12 CR +1 V +1 10/29/25, 20:58

    Reply

    Done

    Feature-107180-IntroducePSR14EventsForBeuserModule.rst:157 Reply

    Done
  19. core-ci voted on patch set 12 V -1 10/29/25, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88050

  20. Oli Bartsch uploaded patch set 13 CR +1 V +1 10/29/25, 21:22

  21. Oli Bartsch voted on patch set 13 CR +1 V +1 10/29/25, 21:23

  22. core-ci voted on patch set 13 V +1 10/29/25, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88054

  23. Benni Mack voted on patch set 13 CR +1 V +1 10/29/25, 21:47

  24. Oli Bartsch voted on patch set 13 CR +2 V +2 10/29/25, 21:51

  25. Oli Bartsch merged patch set 14 10/29/25, 21:51