Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Stale

90204[BUGFIX] Add external links into reference index

Daniel Siepmann CR +1 V +1 Normal +45 −20 updated 09/11/26, 22:18

Commit message

The reference index only handles the soft reference substitution
types "db" and "string". Typolinks to an URL are the only ones
using the type "external", which is therefore silently dropped:
Links to a page or file are indexed as relation, mail and phone
links as "_STRING" row, but external URLs are not indexed at all.

The two typolink soft reference parsers now use "string" for those
as well, which is what UrlSoftReferenceParser does already. No
consumer in the core evaluates "external": ReferenceIndex and
ext:impexp handle "db" and "string" only, linkvalidator determines
external links from the token value.

Note "external" is used for degraded links as well: A "file:42"
link whose sys_file record is gone resolves to an URL pointing into
the TYPO3 root and is now indexed as "_STRING" row, too.

In ext:impexp, external URLs are now offered for substitution on
import and show up with their value in the export preview. Existing
export files are imported as before.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/04/90204/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/04/90204/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1419

  1. Daniel Siepmann uploaded patch set 1 07/31/25, 09:00

  2. core-ci voted on patch set 1 V -1 07/31/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82579

  3. Daniel Siepmann uploaded patch set 2 V -1 07/31/25, 10:03

  4. Daniel Siepmann commented on patch set 2 07/31/25, 10:05

    I'm not sure if this `external` is used by some specific logic, e.g. linkvalidator. We don't have it in our project.
  5. core-ci voted on patch set 2 V -1 07/31/25, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82580

  6. Daniel Siepmann uploaded patch set 3 V -1 07/31/25, 10:30

  7. core-ci voted on patch set 3 V +1 07/31/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82582

  8. Daniel Siepmann marked it work in progress 08/21/25, 06:08

  9. Daniel Siepmann marked it ready for review 08/21/25, 06:08

  10. Stefan Froemken commented on patch set 3 08/22/25, 08:16

    I have added Lolli here. I remember he has cleaned-up Reference Indexing a lot within the last year.
  11. Christian Kuhn commented on patch set 3 08/22/25, 15:11

    this reminds me how much i hate the array api of the softref parsers ... i must admin i don't fully understand the impact of the change without an in-depth review. we should probably at least have some tests for refindex itself to see what actually changes?
  12. Benni Mack updated the commit message in patch set 4 V +1 04/22/26, 06:32

  13. Benni Mack wrote 04/22/26, 06:32

    Hashtag added: lolli-feedback
  14. core-ci voted on patch set 4 V -1 04/22/26, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100727

  15. Christian Kuhn wrote 06/18/26, 23:11

    Removed reviewer Christian Kuhn.
  16. Georg Ringer uploaded patch set 5 V -1 09/09/26, 15:28

  17. core-ci voted on patch set 5 V +1 09/09/26, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108200

  18. Oliver Klee voted on patch set 5 V +1 09/09/26, 16:00

  19. Simon Schaufelberger voted on patch set 5 CR +1 V +1 09/11/26, 22:18