Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90204[BUGFIX] Add external links into reference index
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/04/90204/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/04/90204/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Classes/DataHandling/SoftReference/TypolinkSoftReferenceParser.php+1 −1
- typo3/sysext/core/Classes/DataHandling/SoftReference/TypolinkTagSoftReferenceParser.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/ReferenceIndex/UpdateIndexHandlesSoftrefForExternalLinkImport.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/ReferenceIndex/UpdateIndexHandlesSoftrefForExternalLinkResult.csvnew+11 −0
- typo3/sysext/core/Tests/Functional/Database/ReferenceIndexTest.php+8 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+2 −2
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkTagSoftReferenceParserTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-complex.xml+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-meta.xml+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-site-config.xml+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent.xml+2 −2
Review log 1419
-
Daniel Siepmann uploaded patch set 1 07/31/25, 09:00
-
core-ci voted on patch set 1 V -1 07/31/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82579
-
Daniel Siepmann uploaded patch set 2
V -107/31/25, 10:03 -
Daniel Siepmann commented on patch set 2 07/31/25, 10:05
I'm not sure if this `external` is used by some specific logic, e.g. linkvalidator. We don't have it in our project. -
core-ci voted on patch set 2 V -1 07/31/25, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82580
-
Daniel Siepmann uploaded patch set 3
V -107/31/25, 10:30 -
core-ci voted on patch set 3 V +1 07/31/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82582
-
Daniel Siepmann marked it work in progress 08/21/25, 06:08
-
Daniel Siepmann marked it ready for review 08/21/25, 06:08
-
Stefan Froemken commented on patch set 3 08/22/25, 08:16
I have added Lolli here. I remember he has cleaned-up Reference Indexing a lot within the last year. -
Christian Kuhn commented on patch set 3 08/22/25, 15:11
this reminds me how much i hate the array api of the softref parsers ... i must admin i don't fully understand the impact of the change without an in-depth review. we should probably at least have some tests for refindex itself to see what actually changes? -
Benni Mack updated the commit message in patch set 4
V +104/22/26, 06:32 -
Benni Mack wrote 04/22/26, 06:32
Hashtag added: lolli-feedback -
core-ci voted on patch set 4 V -1 04/22/26, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100727
-
Christian Kuhn wrote 06/18/26, 23:11
Removed reviewer Christian Kuhn. -
Georg Ringer uploaded patch set 5
V -109/09/26, 15:28 -
core-ci voted on patch set 5 V +1 09/09/26, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108200
-
Oliver Klee voted on patch set 5 V +1 09/09/26, 16:00
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 09/11/26, 22:18