Review main Merged

90223[TASK] Resolve ignored `nullsafe.neverNull` PHPStan errors

Elias Häußler CR +2 V +2 Easy +5 −35 updated 08/12/25, 20:15

Commit message

A nullsafe property access is not necessary if used in combination with
the null coalesce operator. This can be verified in the related PHPStan
issue https://github.com/phpstan/phpstan/issues/7109, where this
specific implementation detail was introduced.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Ursula Klinger +1
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Elias Häußler uploaded patch set 1 08/01/25, 17:50

  2. core-ci voted on patch set 1 V +1 08/01/25, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82643

  3. Oliver Klee updated the commit message in patch set 2 V +1 08/02/25, 08:24

  4. core-ci voted on patch set 2 V +1 08/02/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82665

  5. Nikita Hovratov voted on patch set 2 CR +1 V +1 08/02/25, 16:20

  6. Oliver Klee voted on patch set 2 CR +1 V +1 08/03/25, 07:54

  7. Ursula Klinger voted on patch set 2 CR +1 08/07/25, 18:18

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 08/12/25, 20:07

  9. Christian Kuhn merged patch set 3 08/12/25, 20:15